Created attachment 236232 [details] Poudriere log for axc port Attached is the poudriere log. Please find here the portlint and portfmt output on the port Makefile - https://paste.mozilla.org/SEq7P90M.
Created attachment 236233 [details] Security/axc The tar file for the port.
@Cy flagged this port that it should rather install in the STAGEDIR. He further suggested that the STAGEDIR should come before DESTDIR (in the patch file). Given that DESTDIR is in the patch (as always its location) and STAGEDIR is for Makefile, an environment variable is now set to make DESTDIR the same as the STAGEDIR. Hence, no further changes required.
(In reply to Michael Adeyeye Oshin from comment #2) Uhm what? DESTDIR is automatically set to ${STAGEDIR} in MAKE_ENV, there's no reason to explicitly add it. Also, the patch already adds the '-s' option to the command installing the lib, so there's no need to strip it *again* in post-install. Could you please upload in a supported format? Those are: * patch generated by 'git format-patch -1', if you have a commit containing all the changes in your (local) git branch * patch generated from the output of 'git diff', if you have all the changes uncommitted in your working copy * shar, if you don't use git at all (only applicable to new ports)
Backport commit https://github.com/gkdr/axc/commit/ba53eb408f793652495d7d73775c33487e6cc8d0 to make your life a lot easier :-)
(In reply to Felix Palmen from comment #3) I might have clicked on the wrong link from this small form-factor device. It seems I deleted a comment in wanting to hit the reply button. Kindly repost; my apologies. I wanted to refer you to the comment here - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265966#c6.
Created attachment 236245 [details] Patch for axc * Backport upstream commit c287e25143fc54486c8a8a86f9abb64ce1753372 and ba53eb408f793652495d7d73775c33487e6cc8d0 * Switch to CMake * Add test target Compile and runtime tested on FreeBSD 13.1-STABLE #0 stable/13-n251817-0c4d13c521a (amd64) (make, make check-plist, make test) Poudriere testport OK 12.3-RELEASE (amd64)
Created attachment 236279 [details] Security/axc: New Poudriere Log The patch is now applied and security/axc was successfully built. $ portlint security/axc looks fine. portfmt at https://paste.mozilla.org/Z8QAKUxF
Created attachment 236280 [details] Security/axc: The Updated Tar file The updated tar file, after applying the patch, is attached.
Created attachment 236281 [details] Poudriere Log with the AXC_TEST Enabled It threw error. However, on selecting the 'build and/or run test' at make config, followed by 'make install clean' passed. Here is its log - https://paste.mozilla.org/50TvZivX. Perhaps, the poudriere jail lacked the test lib to build the test.
Additional test results: ***make check-plist*** ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) ***make test*** ===> Testing for axc-0.3.7 ===> axc-0.3.7 depends on package: cmocka>=1.1.5 - found
As I understand, you'd be fine with the variant suggested by diizzy@ (which pulls in the new cmake build system from upstream patches)? So, I'll take this now and run a few tests on it, also double-checking the new test target.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d7813e3aeb6da2b982eeab6696b9090632c5e692 commit d7813e3aeb6da2b982eeab6696b9090632c5e692 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-08-30 15:06:33 +0000 Commit: Felix Palmen <zirias@FreeBSD.org> CommitDate: 2022-09-06 16:42:12 +0000 security/axc: Add new port Client lib providing crypto interfaces for libsignal-protocol-c. PR: 266104 Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D36468 security/Makefile | 1 + security/axc/Makefile (new) | 32 ++++++++++++++++++++++++++++++++ security/axc/distinfo (new) | 7 +++++++ security/axc/pkg-descr (new) | 8 ++++++++ security/axc/pkg-plist (new) | 7 +++++++ 5 files changed, 55 insertions(+)
Committed, thanks!