Bug 266186 - devel/avrdude: Add patch for AVR Dragon JTAG fix that didn't make it into 7.0
Summary: devel/avrdude: Add patch for AVR Dragon JTAG fix that didn't make it into 7.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-03 01:00 UTC by Craig Leres
Modified: 2022-11-26 21:40 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joerg)


Attachments
patch (1.02 KB, patch)
2022-09-03 01:01 UTC, Craig Leres
leres: maintainer-approval? (joerg)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer freebsd_triage 2022-09-03 01:00:53 UTC
At some point after 5.11 avrdude started leaving the target stopped upon completion of a JTAG transaction. I filed a github issue about this issue:

    https://github.com/avrdudes/avrdude/issues/366

This is super annoying because, for example, the target does not boot after JTAG programming. Others were seeing this and shortly after 7.0 was released, MCUdude created a PR which has since been merged:

    https://github.com/avrdudes/avrdude/pull/979

Here's a patch to apply this PR.
Comment 1 Craig Leres freebsd_committer freebsd_triage 2022-09-03 01:01:53 UTC
Created attachment 236323 [details]
patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-11-26 21:14:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dc3fbc6a0213e8f02348d29695254253440ce254

commit dc3fbc6a0213e8f02348d29695254253440ce254
Author:     Craig Leres <leres@FreeBSD.org>
AuthorDate: 2022-11-26 21:13:27 +0000
Commit:     Craig Leres <leres@FreeBSD.org>
CommitDate: 2022-11-26 21:13:27 +0000

    devel/avrdude: Add patch for AVR Dragon JTAG fix that didn't make it into 7.0

    At some point after 5.11 avrdude started leaving the target stopped
    upon completion of a JTAG transaction. I filed a github issue about
    this issue:

        https://github.com/avrdudes/avrdude/issues/366

    This is super annoying because, for example, the target does not
    boot after JTAG programming. Others were seeing this and shortly
    after 7.0 was released, MCUdude created a PR which has since been
    merged:

        https://github.com/avrdudes/avrdude/pull/979

    Apply this patch.

    PR:             266186
    Approved by:    joerg (maintainer timeout, 12 weeks)

 devel/avrdude/Makefile                         |  2 +-
 devel/avrdude/files/patch-src_jtagmkII.c (new) | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)
Comment 3 Joerg Wunsch freebsd_committer freebsd_triage 2022-11-26 21:32:02 UTC
Seriously, I don't see much point in pulling individual patches out of an ongoing development. Where would you want to stop, which patches to include?

I would have preferred to wait until AVRDUDE 7.1 is released.
Comment 4 Craig Leres freebsd_committer freebsd_triage 2022-11-26 21:40:34 UTC
(In reply to Joerg Wunsch from comment #3)
Sorry about that, I was just trying to solve a problem I've been banging into since 2014 and I never received any maintainer feedback on this PR.