Bug 266334 - audio/yoshimi: Use upstream release archive
Summary: audio/yoshimi: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-10 08:03 UTC by Daniel Engberg
Modified: 2022-09-11 05:21 UTC (History)
0 users

See Also:

Attachments
Patch for yoshimi (1.24 KB, patch)
2022-09-10 08:03 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-09-10 08:03:39 UTC 
Created attachment 236468 [details]
Patch for yoshimi

Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section)

Poudriere testport OK 12.3-RELEASE (amd64)
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2022-09-10 14:59:13 UTC 
Thanks for the patch, Daniel!

I'll fix CFLAGS at a later time.

-------------

Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-09-10 14:59:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f35d4cee10483771dc64aff575d337b75f5a4cbc

commit f35d4cee10483771dc64aff575d337b75f5a4cbc
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-09-10 14:57:24 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-09-10 14:59:18 +0000

    audio/yoshimi: Use upstream release archive

    PR:             266334

 audio/yoshimi/Makefile | 6 ++----
 audio/yoshimi/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 7 deletions(-)
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-09-10 15:05:50 UTC 
(In reply to Daniel Engberg from comment #1)

I can't confirm that it overrides CFLAGS.
When I added -O5 to CFLAGS and CXXFLAGS -O5 appeared in all compile lines.


Yuri
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-09-10 15:48:13 UTC 
(In reply to Yuri Victorovich from comment #4)
...
[ 63% 132/205] /usr/bin/c++ -DGUI_FLTK -DMIN_CONFIG_MAJOR=2 -DMIN_CONFIG_MINOR=0 -DYOSHIMI=\"yoshimi\" -DYOSHIMI_LV2_PLUGIN=1 -DYOSHI_FIFO_DIR=\"\" -Dyoshimi_lv2_EXPORTS -I/wrkdirs/usr/ports/audio/yoshimi/work/.build/LV2_Plugin -I/wrkdirs/usr/ports/audio/yoshimi/work/yoshimi-2.2.2/src/LV2_Plugin -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/wrkdirs/usr/ports/audio/yoshimi/work/yoshimi-2.2.2/src -ffast-math -fomit-frame-pointer -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O3 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -std=gnu++14

It overrides defaults set by ports framework

Best regards,
Daniel
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-09-11 05:21:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a0f04a976b000e49180daf7ba52e67826018dca

commit 5a0f04a976b000e49180daf7ba52e67826018dca
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-09-11 05:06:12 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-09-11 05:21:26 +0000

    audio/yoshimi: Not override port defaults for CMAKE_BUILD_TYPE and CXXFLAGS

    PR:             266334
    Reported by:    Daniel Engberg <diizzy@FreeBSD.org>

 audio/yoshimi/files/patch-src_CMakeLists.txt (new) | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)