Created attachment 236473 [details] devel/gopls: update to 0.9.5 - bugfix for redundant reloads following go.mod changes Changelog: https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.5 A bug fix release. Please MFH if possible. Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3a55123fc082cc0faab8a960f33a42df2757447d commit 3a55123fc082cc0faab8a960f33a42df2757447d Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-09-10 15:17:07 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-09-10 15:19:12 +0000 devel/gopls: Update to 0.9.5 - bugfix for redundant reloads following go.mod changes Changelog: https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.5 PR: 266338 devel/gopls/Makefile | 3 +-- devel/gopls/distinfo | 10 +++++----- 2 files changed, 6 insertions(+), 7 deletions(-)
Hi, I'm testing 0.9.5 on 2022Q3 (go118): --- package name: gopls-0.9.5 building for: FreeBSD 131amd64Q-devel 13.1-RELEASE-p1 (...) ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/doc/inlayHints.md ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. --- It seems that an additional file was created in stagedir but pkg-plist didn't change from 0.9.4 -> 0.9.5. I think it is risky to add it to pkg-plist until is found why this is happening. Any clues? :) Cheers
Thank you for noticing that! The file was added in commit 79db7c0, but it seems like that update got lost during the MFH process. Please add the file to pkg-plist to make the build succeed. It is already present in the main branch.
A commit in branch 2022Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=81994e494bfae2503a2e33948dfe505269689eab commit 81994e494bfae2503a2e33948dfe505269689eab Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-09-10 15:17:07 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-09-10 17:09:37 +0000 devel/gopls: Update to 0.9.5 - bugfix for redundant reloads following go.mod changes Changelog: https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.5 PR: 266338 (cherry picked from commit 3a55123fc082cc0faab8a960f33a42df2757447d) devel/gopls/Makefile | 3 ++- devel/gopls/distinfo | 10 +++++----- devel/gopls/pkg-descr | 2 -- devel/gopls/pkg-plist | 1 + 4 files changed, 8 insertions(+), 8 deletions(-)
Committed, thanks!
Note that 2022Q3 does not yet have the WWW change. It doesn't cause any catastrophic damage though.
A commit in branch 2022Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=44c06015bd44b7b876b80335155af3004521dc0e commit 44c06015bd44b7b876b80335155af3004521dc0e Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2022-09-10 15:17:07 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-09-10 18:17:53 +0000 devel/gopls: Update to 0.9.5 - bugfix for redundant reloads following go.mod changes Changelog: https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.5 PR: 266338 (cherry picked from commit 3a55123fc082cc0faab8a960f33a42df2757447d) devel/gopls/Makefile | 2 +- devel/gopls/distinfo | 10 +++++----- devel/gopls/pkg-plist | 1 + 3 files changed, 7 insertions(+), 6 deletions(-)
(In reply to Robert Clausecker from comment #6) Yes you are right, 2022Q3 isn't changed yet for Makefile WWW. I've looked at recent quarterly commits and all preserve old pkg-descr WWW. Fixed.