Bug 266449 - net-p2p/go-ethereum upgrade to 1.10.25
Summary: net-p2p/go-ethereum upgrade to 1.10.25
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-16 17:33 UTC by Enrique Fynn
Modified: 2022-09-24 05:05 UTC (History)
1 user (show)

See Also:

Attachments
go-ethereum-1.10.25.patch (15.73 KB, patch)
2022-09-16 17:33 UTC, Enrique Fynn 		me: maintainer-approval+
Details | Diff
go-ethereum-1.10.25.patch (1.65 KB, patch)
2022-09-20 17:42 UTC, Enrique Fynn 		me: maintainer-approval+
Details | Diff
go-ethereum-1.10.25.patch (1.25 KB, patch)
2022-09-22 18:28 UTC, Enrique Fynn 		me: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Fynn 2022-09-16 17:33:21 UTC 
Created attachment 236596 [details]
go-ethereum-1.10.25.patch

Upgrade go-ethereum to 1.10.25

Release notes:
https://github.com/ethereum/go-ethereum/releases/tag/v1.10.25
https://github.com/ethereum/go-ethereum/releases/tag/v1.10.24
Comment 1 Guangyuan Yang freebsd_committer freebsd_triage 2022-09-18 02:16:29 UTC 
Seems to be missing a lot of stuff in distinfo.

=======================<phase: fetch          >============================
===>  License GPLv3 accepted by the user
===>   go-ethereum-1.10.25 depends on file: /usr/local/sbin/pkg - found
=> ethereum-go-ethereum-v1.10.25_GH0.tar.gz doesn't seem to exist in /portdistfiles/.
=> Attempting to fetch https://codeload.github.com/ethereum/go-ethereum/tar.gz/v1.10.25?dummy=/ethereum-go-ethereum-v1.10.25_GH0.tar.gz
ethereum-go-ethereum-v1.10.25_GH0.tar.gz                12 MB  127 MBps    00s
=> Azure-azure-sdk-for-go-5b8bb8b1cef1_GH0.tar.gz is not in /usr/ports/net-p2p/go-ethereum/distinfo.
=> Either /usr/ports/net-p2p/go-ethereum/distinfo is out of date, or
=> Azure-azure-sdk-for-go-5b8bb8b1cef1_GH0.tar.gz is spelled incorrectly.
*** Error code 1

Stop.
make: stopped in /usr/ports/net-p2p/go-ethereum

Log: http://jenkins.ygy.io/job/freebsd-ports-testing-13.1R-amd64/1997/console
Comment 2 Enrique Fynn 2022-09-20 17:42:19 UTC 
Created attachment 236709 [details]
go-ethereum-1.10.25.patch

Oops... Sorry about that, I've uploaded the correct patch.
Comment 3 Guangyuan Yang freebsd_committer freebsd_triage 2022-09-21 23:25:50 UTC 
Will be committed with PORTREVISION removed.
Comment 4 Guangyuan Yang freebsd_committer freebsd_triage 2022-09-21 23:27:11 UTC 
Actually, could you move WWW back? It was in the right position - also please remove PORTREVISION when bumping the version, thanks.
Comment 5 Enrique Fynn 2022-09-22 18:28:29 UTC 
Created attachment 236752 [details]
go-ethereum-1.10.25.patch

Hi Guangyuan, thanks!
Removed PORTREVISION and moved WWW back

I moved WWW because `portlint` told me that was not the correct place for it :/
Comment 6 Guangyuan Yang freebsd_committer freebsd_triage 2022-09-23 21:54:16 UTC 
(In reply to Enrique Fynn from comment #5)

Thanks! I recalled that portlint should be updated for this as well, maybe upgrade it :)
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-09-23 23:22:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=41975a820eb04be63ec889a21787398f74be4afa

commit 41975a820eb04be63ec889a21787398f74be4afa
Author:     Enrique Fynn <me@enriquefynn.com>
AuthorDate: 2022-09-23 23:21:26 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2022-09-23 23:21:26 +0000

    net-p2p/go-ethereum: Update to 1.10.25

    Changelog:      https://github.com/ethereum/go-ethereum/releases/tag/v1.10.25

    PR:             266449

 net-p2p/go-ethereum/Makefile | 3 +--
 net-p2p/go-ethereum/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)