Bug 266476 - japanese/mecab-ipadic: Fix build when BATCH is defined
Summary: japanese/mecab-ipadic: Fix build when BATCH is defined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-18 05:10 UTC by Yoshihiro Takahashi
Modified: 2022-11-28 13:04 UTC (History)
2 users (show)

See Also:

Attachments
Fix build (1.28 KB, patch)
2022-09-18 05:10 UTC, Yoshihiro Takahashi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshihiro Takahashi freebsd_committer freebsd_triage 2022-09-18 05:10:49 UTC 
Created attachment 236653 [details]
Fix build

There is the following error when BATCH is defined.
The attached patch fixes this problem to remove LICENSE* variables if USES=metaport is set.

# cd /usr/ports/japanese/mecab-ipadic
# make BATCH=
===>  ja-mecab-ipadic-2.7.0.20070801_1 License NA needs confirmation, but
BATCH is defined.
*** Error code 1

Stop.
make: stopped in /usr/ports/japanese/mecab-ipadic
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2022-11-25 09:19:48 UTC 
The issue does not reproduce with current ports tree.
# make BATCH=  -C /usr/ports/japanese/mecab-ipadic clean stage
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2022-11-25 14:49:08 UTC 
It might be too early to close this. Is this still an issue? Can you reproduce this with current ports tree head?
Comment 3 Yoshihiro Takahashi freebsd_committer freebsd_triage 2022-11-26 04:52:37 UTC 
The issue was fixed by metaport.mk instead of changing individual ports.
See: https://cgit.freebsd.org/ports/commit/Mk/Uses/metaport.mk?id=6d5f280b6186b8586aa1392c6d90ad45df52d305

But my patch is worth committing to follow metaport rules.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-11-28 12:57:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5252c86d935a65107fda89bff9aed8e02c9fb08

commit a5252c86d935a65107fda89bff9aed8e02c9fb08
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2022-11-28 12:52:53 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-11-28 12:55:45 +0000

    japanese/mecab-ipadic: Do not set LICENSE for metaport

    as metaport itself does not any LICENSE.

    PR:             266476

 japanese/mecab-ipadic/Makefile | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2022-11-28 13:04:28 UTC 
Committed, thanks!