Bug 266634 - rtsold(8) and rtsol(8) usage() functions: corrections
Summary: rtsold(8) and rtsol(8) usage() functions: corrections
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-bugs (Nobody)
URL: https://www.freebsd.org/cgi/man.cgi?q...
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2022-09-26 18:30 UTC by ghuckriede
Modified: 2025-01-28 16:06 UTC (History)
3 users (show)

See Also:


Attachments
Screenshot: option -i in a FreeBSD 13.1-RELEASE-p2 view of the manual page (60.97 KB, image/png)
2022-09-27 01:57 UTC, Graham Perrin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description ghuckriede 2022-09-26 18:30:48 UTC
The '-i' parameter (new in 13.1) is missing when the usage is displayed on the command line.
It appears https://reviews.freebsd.org/D32956 failed to add `-i` to the usage() function.

Discovered in FBSD 13.1.
This is still the case on HEAD@6914ffef4e2318ca1d0ead28eafb6f06055ce0f8
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-09-27 01:01:25 UTC
(In reply to ghuckriede from comment #0)

> The '-i' parameter (new in 13.1) is missing when the usage is displayed 
> on the command line. …


<https://github.com/freebsd/freebsd-src/commit/a0fc5094bf4c594f2717cd1b757b1b5daca61d3f>

>> releng/13.1 stable/13

– and <https://github.com/freebsd/freebsd-src/commit/a0fc5094bf4c594f2717cd1b757b1b5daca61d3f#diff-1c56fa78ab13de5ff16dbe8570000deb9e72040c39b98d85a990cc1a86e97725R197>. 

Hmm …
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2022-09-27 01:57:51 UTC
Created attachment 236855 [details]
Screenshot: option -i in a FreeBSD 13.1-RELEASE-p2 view of the manual page

Not reproducible here. Screenshot attached. 

ghuckriede, please run: 

freebsd-version -kru

– what's reported?
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-09-27 02:16:36 UTC
Sorry, I misunderstood. Please ignore comment 1 and comment 2. 

Confirmed: 

% rtsold
usage: rtsold [-dDfFm1] [-O script-name] [-p pidfile] [-R script-name] interface ...
usage: rtsold [-dDfFm1] [-O script-name] [-p pidfile] [-R script-name] -a
% uname -KU
1400067 1400067
%
Comment 4 ghuckriede 2022-09-27 13:18:16 UTC
Graham,
Sorry for not being more clear.  You figured it out before I could get back to you.

Upon further inspection, other options appear to be missing in the usage() function (`-i`, `-M [opt]`, `-u`).  Also `-p` needs to be removed from `rtsol`.
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-01-17 19:21:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c4380d5b9383e2a062840573b36ab643b65b2610

commit c4380d5b9383e2a062840573b36ab643b65b2610
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2025-01-17 15:14:22 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-01-17 19:20:14 +0000

    rtsold: Add -i to the usage message

    PR:             266634
    Fixes:          231bac4ccc43 ("rtsol/rtsold: Add option to skip random delay")
    MFC after:      1 week

    (cherry picked from commit 9e9e64b693ab1e08cca46e26e468160542c33f3a)

 usr.sbin/rtsold/rtsold.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-01-24 14:36:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=5db50a3167ac7a4f18088a5cfdaac64aa925c32e

commit 5db50a3167ac7a4f18088a5cfdaac64aa925c32e
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2025-01-24 14:06:59 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-01-24 14:06:59 +0000

    rtsold: Further usage message updates

    Add -u, remove -p from the rtsol(8) usage message.

    PR:             266634
    MFC after:      1 week

 usr.sbin/rtsold/rtsold.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-01-28 16:01:21 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3ba946aebf747e12da4fb22ee0e45ee0e3a233ee

commit 3ba946aebf747e12da4fb22ee0e45ee0e3a233ee
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2025-01-17 15:14:22 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-01-28 16:00:12 +0000

    rtsold: Add -i to the usage message

    PR:             266634
    Fixes:          231bac4ccc43 ("rtsol/rtsold: Add option to skip random delay")
    MFC after:      1 week

    (cherry picked from commit 9e9e64b693ab1e08cca46e26e468160542c33f3a)
    (cherry picked from commit c4380d5b9383e2a062840573b36ab643b65b2610)

 usr.sbin/rtsold/rtsold.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2025-01-28 16:01:27 UTC
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=cd1f435f4819935155d660aca97b6967d7992846

commit cd1f435f4819935155d660aca97b6967d7992846
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2025-01-24 14:06:59 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-01-28 16:00:34 +0000

    rtsold: Further usage message updates

    Add -u, remove -p from the rtsol(8) usage message.

    PR:             266634
    MFC after:      1 week

    (cherry picked from commit 5db50a3167ac7a4f18088a5cfdaac64aa925c32e)

 usr.sbin/rtsold/rtsold.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)