Bug 266842 - graphics/vulkan-tools: Disable compiler warnings as errors
Summary: graphics/vulkan-tools: Disable compiler warnings as errors
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: regression
Depends on:
Blocks: 266721
  Show dependency tree / graph
 
Reported: 2022-10-05 13:25 UTC by Daniel Engberg
Modified: 2022-10-05 15:23 UTC (History)
0 users

See Also:
diizzy: maintainer-feedback?

Attachments
Patch for vulkan-tools (515 bytes, patch)
2022-10-05 13:25 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-10-05 13:25:21 UTC 
Created attachment 237098 [details]
Patch for vulkan-tools

As of PR 266721 BUILD_WERROR needs to be turned off to port to compile

Compile tested on 13.1-STABLE (amd64)
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-10-05 15:10:36 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2663085f868eb72a8495562cd97ef5fdce88d175

commit 2663085f868eb72a8495562cd97ef5fdce88d175
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-10-05 15:06:56 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-10-05 15:09:57 +0000

    graphics/vulkan-tools: unbreak with -DNDEBUG after 7c313a5dcadd

    cube/cube.c:3122:14: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
        VkResult result;
                 ^

    PR:             266842
    Reported by:    diizzy, antoine (via exp-run)

 graphics/vulkan-tools/Makefile | 3 +++
 graphics/vulkan-tools/distinfo | 2 ++
 2 files changed, 5 insertions(+)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-10-05 15:23:34 UTC 
Thanks Jan for fixing and upstreaming.

Best regards,
Daniel