Created attachment 237130 [details] Patch to upgrade audacity to 3.2.1 Updated cmake flags to current. Fixes crash on startup on some systems. vst3 support still broken and is disabled. Added new manual option to install manual.
^Triage: Bugfix release, merge to quarterly branch. ^Triage: Maintainer-feedback flag (+) not required unless requested (?) first. Q/A: patch did not apply cleanly. Would you mind checking it? The patch contains CRLF terminators. No need to update a new patch though. Thanks!
(In reply to Fernando Apesteguía from comment #1) not sure how those line endings magically appear once in a while
(In reply to Jack from comment #2) Did you copy-paste the patch in bugzilla instead of attaching? That might be it.
(In reply to Fernando Apesteguía from comment #3) I scp from bsd test vm to bsd host server, then scp to bsd home server, then used a windows laptop to download file from bsd home server, then uploaded that file to bugzilla and checked "patch". Maybe the download over ftp on windows added interesting chars? I'm about to use my bsd desktop to upload the patch now as I don't see any interesting chars on that desktop. If there's still bad line endings, must be from the browser?
Created attachment 237134 [details] Upgrade to audacity 3.2.1 hopefully without bad line endings
(In reply to Jack from comment #4) If FTP is that FTP, it is always better to use binary mode (TYPE I). If your windows is 10, you can use openssh client. I forget where that setting is :)
Yep, this is OK file audacity.txt: unified diff output, ASCII text
it must be that darned ftp on the windows pc, guess need to not ftp on windows :)
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6d2fef1844e1236a1e1c5c53664243bc46eb230e commit 6d2fef1844e1236a1e1c5c53664243bc46eb230e Author: Jack <xxjack12xx@gmail.com> AuthorDate: 2022-10-07 05:47:28 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-10-09 11:55:28 +0000 audio/audacity: Upgrade audacity to 3.2.1 ChangeLog: https://github.com/audacity/audacity/releases/tag/Audacity-3.2.1 * Fixed Audacity crashing on startup on some systems. * Fixed a crash when applying Waves Berzerk Distortion Mono to a mono track * Fixed a freeze when very quickly starting and stopping playback. * macOS: Homebrew FFmpeg installs are now found automatically * macOS: Fixed Melda VST Plugin UI * Building with VST3 support is now possible without Conan. PR: 266874 Reported by: xxjack12xx@gmail.com (maintainer) audio/audacity/Makefile | 42 +- audio/audacity/distinfo | 6 +- .../files/patch-cmake-proxies_CMakeLists.txt | 4 +- audio/audacity/pkg-plist | 1393 +++++++++++++++++++- 4 files changed, 1424 insertions(+), 21 deletions(-)