Created attachment 237261 [details] proposed fix Once upon a time there was a bug #90 in Smokeping: https://github.com/oetiker/SmokePing/issues/90 It occured because the software parses output of fping utility instead of checking its version and the output format changes in time. The bugfix was incomplete as it fixed the problem in FPing.pm but same code is in FPingContinuous.pm and same bug was not fixed there. The problem's reported as bug #341 three weeks ago but neglected: https://github.com/oetiker/SmokePing/issues/341 Let us add same fix as in #90 to our port to fix FPingContinuous.pm until its fixed upstream.
Forgot to note, that this problem makes it silently ignore "sourceaddress" setting for a proble that may result in completely wrong path for probe packets and misleading graphs.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=55c01f69543c6336bb583857019f5278d4bf90ef commit 55c01f69543c6336bb583857019f5278d4bf90ef Author: Eugene Grosbein <eugen@FreeBSD.org> AuthorDate: 2022-11-04 15:27:04 +0000 Commit: Eugene Grosbein <eugen@FreeBSD.org> CommitDate: 2022-11-04 15:27:04 +0000 net-mgmt/smokeping: fix bug in FPingContinuous.pm Add patch accepted upstream with bug #341. https://github.com/oetiker/SmokePing/issues/341 PR: 267015 Approved by: rodrigo (maintainer timeout, 3 weeks) net-mgmt/smokeping/Makefile | 2 +- .../patch-lib_Smokeping_probes_FPingContinuous.pm (new) | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-)