Bug 267018 - dns/unbound: Update to 1.17.0
Summary: dns/unbound: Update to 1.17.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://www.nlnetlabs.nl/news/2022/Oc...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-13 14:12 UTC by Jaap Akkerhuis
Modified: 2022-10-16 17:43 UTC (History)
2 users (show)

See Also:
fernape: merge-quarterly+


Attachments
patch to update (2.34 KB, patch)
2022-10-13 14:12 UTC, Jaap Akkerhuis
jaap: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaap Akkerhuis 2022-10-13 14:12:55 UTC
Created attachment 237264 [details]
patch to update

This release has new interface acl configuration options. These
allow access-control actions, per interface. Also tags, and views
can be configured per interface, queries over the interface are
answered with these tags and views. It is configured with the
options `interface-action`, `interface-tag`, `interface-tag-action`,
`interface-tag-data` and `interface-view`. If there is also an
access-control setting for the query, this overrides the interface
settings for that query.

The PROXYv2 protocol is supported. It can be configured with the
`proxy-protocol-port: portno` option. It is used to convey the
IP addresses of clients that connect via a proxy to Unbound.

There are also fixes for a number of bugs. In some cases a
blocking wait on a socket could happen, and this has been
fixed. If the upstream sends a TC flag, erroneously, the reply
is ignored and retried. When under load, with the new
NRDelegation fixes from the previous release, there are
mitigations to continue target discovery. There is also a fix
for possible loops in the tcp reuse code.

The release version differs from the RC1, there is a bugfix
for the proxy protocol for tcp read when no proxied addresses
are provided.

Features
- Merge #753: ACL per interface. (New interface-* configuration
  options).
- Merge #760: PROXYv2 downstream support. (New proxy-protocol-port
  configuration option).

Bug Fixes
- Fix #728: alloc_reg_obtain() core dump. Stop double
  alloc_reg_release when serviced_create fails.
- Fix edns subnet so that scope 0 answers only match sourcemask 0
  queries for answers from cache if from a query with sourcemask 0.
- Fix unittest for edns subnet change.
- Merge #730 from luisdallos: Fix startup failure on Windows 8.1 due
  to unsupported IPV6_USER_MTU socket option being set.
- Fix ratelimit inconsistency, for ip-ratelimits the value is the
  amount allowed, like for ratelimits.
- Fix #734 [FR] enable unbound-checkconf to detect more (basic)
  errors.
- Fix to log accept error ENFILE and EMFILE errno, but slowly, once
  per 10 seconds. Also log accept failures when no slow down is used.
- Fix to avoid process wide fcntl calls mixed with nonblocking
  operations after a blocked write.
- Patch from Vadim Fedorenko that adds MSG_DONTWAIT to receive
  operations, so that instruction reordering does not cause mistakenly
  blocking socket operations.
- Fix to wait for blocked write on UDP sockets, with a timeout if it
  takes too long the packet is dropped.
- Fix for wait for udp send to stop when packet is successfully sent.
- Fix #741: systemd socket activation fails on IPv6.
- Fix to update config tests to fix checking if nonblocking sockets
  work on OpenBSD.
- Slow down log frequency of write wait failures.
- Fix to set out of file descriptor warning to operational verbosity.
- Fix to log a verbose message at operational notice level if a
  thread is not responding, to stats requests. It is logged with
  thread identifiers.
- Remove include that was there for debug purposes.
- Fix to check pthread_t size after pthread has been detected.
- Convert tdir tests to use the new skip_test functionality.
- Remove unused testcode/mini_tpkg.sh file.
- Better output for skipped tdir tests.
- Fix doxygen warning in respip.h.
- Fix to remove erroneous TC flag from TCP upstream.
- Fix test tdir skip report printout.
- Fix windows compile, the identifier interface is defined in headers.
- Fix to close errno block in comm_point_tcp_handle_read outside of
  ifdef.
- Fix static analysis report to remove dead code from the
  rpz_callback_from_iterator_module function.
- Fix to clean up after the acl_interface unit test.
- Merge #764: Leniency for target discovery when under load (for
  NRDelegation changes).
- Use DEBUG_TDIR from environment in mini_tdir.sh for debugging.
- Fix string comparison in mini_tdir.sh.
- Make ede.tdir test more predictable by using static data.
- Fix checkconf test for dnscrypt and proxy port.
- Fix dnscrypt compile for proxy protocol code changes.
- Fix to stop responses with TC flag from resulting in partial
  responses. It retries to fetch the data elsewhere, or fails the
  query and in depth fix removes the TC flag from the cached item.
- Fix proxy length debug output printout typecasts.
- Fix to stop possible loops in the tcp reuse code (write_wait list
  and tcp_wait list). Based on analysis and patch from Prad Seniappan
  and Karthik Umashankar.
- Fix PROXYv2 header read for TCP connections when no proxied addresses
  are provided.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-14 05:43:19 UTC
Having so many fixes, is this something we would like to have in 2022Q4?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-10-14 07:02:45 UTC
distfiles.crux.guru throws certificate errors
Comment 3 Jaap Akkerhuis 2022-10-15 14:11:19 UTC
(In reply to Fernando Apesteguía from comment #1)
We have had updates with even more fixes that went through without any problems. The all seem pretty benign. But go ahead I you think it is needed.
Comment 4 Jaap Akkerhuis 2022-10-15 14:23:43 UTC
(In reply to Daniel Engberg from comment #2)
Somebody (not me) added this to the port. So let's remove it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-10-16 17:42:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7b0d6de05baabfbcd7a25fd0440ee3bf1f3bc23e

commit 7b0d6de05baabfbcd7a25fd0440ee3bf1f3bc23e
Author:     Jaap Akkerhuis <jaap@NLnetLabs.nl>
AuthorDate: 2022-10-14 05:39:04 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-16 17:37:54 +0000

    dns/unbound: Update to 1.17.0

    ChangeLog: https://www.nlnetlabs.nl/news/2022/Oct/13/unbound-1.17.0-released/

    Remove additional MASTER_SITES (certificate error)

    PR:             267018
    Reported by:    jaap@NLnetLabs.nl (maintainer)
    Reviewed by:    diizzy@

 dns/unbound/Makefile         | 7 +++----
 dns/unbound/distinfo         | 6 +++---
 dns/unbound/files/unbound.in | 5 +++--
 dns/unbound/pkg-plist        | 2 +-
 4 files changed, 10 insertions(+), 10 deletions(-)
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-10-16 17:43:22 UTC
Committed and merged to 2022Q4,

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-10-16 17:43:24 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fdbc5d894736afd0e65017da1b26a972bdb7e139

commit fdbc5d894736afd0e65017da1b26a972bdb7e139
Author:     Jaap Akkerhuis <jaap@NLnetLabs.nl>
AuthorDate: 2022-10-14 05:39:04 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-10-16 17:39:25 +0000

    dns/unbound: Update to 1.17.0

    ChangeLog: https://www.nlnetlabs.nl/news/2022/Oct/13/unbound-1.17.0-released/

    Remove additional MASTER_SITES (certificate error)

    PR:             267018
    Reported by:    jaap@NLnetLabs.nl (maintainer)
    Reviewed by:    diizzy@

    (cherry picked from commit 7b0d6de05baabfbcd7a25fd0440ee3bf1f3bc23e)

 dns/unbound/Makefile         | 7 +++----
 dns/unbound/distinfo         | 6 +++---
 dns/unbound/files/unbound.in | 5 +++--
 dns/unbound/pkg-plist        | 2 +-
 4 files changed, 10 insertions(+), 10 deletions(-)