Bug 267053 - Add support for AMT virtual serial port (C610/X99 series)
Summary: Add support for AMT virtual serial port (C610/X99 series)
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Li-Wen Hsu
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-10-14 15:48 UTC by Stuart McLaren
Modified: 2022-12-28 15:13 UTC (History)
2 users (show)

See Also:

Attachments
Diff for sys/dev/uart/uart_bus_pci.c (631 bytes, patch)
2022-10-14 15:48 UTC, Stuart McLaren 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart McLaren 2022-10-14 15:48:42 UTC 
Created attachment 237303 [details]
Diff for sys/dev/uart/uart_bus_pci.c

Allow connecting to the virtual serial port of machines which have this chipset.

eg The HP Z640 workstation.

An example of using "amtterm" to connect to the virtual serial port of a Z640 with this kernel patch applied:

----------------------------------

$ amtterm myworkstation
serial-over-lan redirection ok
connected now, use ^] to escape

FreeBSD/amd64 (myworkstation) (ttyu0)

login:

----------------------------------
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2022-10-15 20:57:36 UTC 
Given that we now use the "patch" keyword, the Summary no longer needs it.
Comment 2 Stuart McLaren 2022-10-15 22:54:19 UTC 
fwiw, when you search "contribute" from the homepage (freebsd.org) you get directed to this link:

https://docs.freebsd.org/en/articles/contributing/#contrib-general

which says

> If the patch is suitable to be applied to the source tree put [PATCH] in the
> synopsis of the report

Should that doc be updated?
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2022-10-16 02:52:23 UTC 
(In reply to stuartinhavana from comment #2)
Yes.
Comment 4 Li-Wen Hsu freebsd_committer freebsd_triage 2022-10-22 18:18:12 UTC 
Thanks for the patch, if possible, can you set your name in https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account so we can use it in `git commit --author` ?
Comment 5 Stuart McLaren 2022-10-22 23:38:05 UTC 
> can you set your name

Sure (done).
Comment 6 Stuart McLaren 2022-11-03 11:53:05 UTC 
Hi,

Is there anything else needed from me at this point?

Also - is this likely to make the 14.0 release?

Thanks.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-12-20 15:57:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=68ca3a155321a4d68afd6a4f0e940dbbcb6917b6

commit 68ca3a155321a4d68afd6a4f0e940dbbcb6917b6
Author:     Stuart McLaren <stuartinhavana@yahoo.com>
AuthorDate: 2022-12-20 14:58:32 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-12-20 15:56:00 +0000

    uart(4): Add support for AMT virtual serial port (C610/X99 series)

    PR:             267053
    MFC after:      3 days

 sys/dev/uart/uart_bus_pci.c | 2 ++
 1 file changed, 2 insertions(+)
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-12-28 15:13:03 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=f3e8aee2ca6cd02d73988f248e7161ff45369a03

commit f3e8aee2ca6cd02d73988f248e7161ff45369a03
Author:     Stuart McLaren <stuartinhavana@yahoo.com>
AuthorDate: 2022-12-20 14:58:32 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-12-28 15:09:12 +0000

    uart(4): Add support for AMT virtual serial port (C610/X99 series)

    PR:             267053
    MFC after:      3 days

    (cherry picked from commit 68ca3a155321a4d68afd6a4f0e940dbbcb6917b6)

 sys/dev/uart/uart_bus_pci.c | 2 ++
 1 file changed, 2 insertions(+)