Bug 267112 - www/nginx: can it be build with STREAM_REALIP?
Summary: www/nginx: can it be build with STREAM_REALIP?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-16 05:22 UTC by kulikov.a
Modified: 2023-03-26 17:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joneum)

Attachments
Possible Makefile patch (1.58 KB, patch)
2023-02-22 07:46 UTC, kulikov.a 		no flags Details | Diff
Possible description patch (502 bytes, patch)
2023-02-22 07:47 UTC, kulikov.a 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kulikov.a 2022-10-16 05:22:14 UTC 
Hi!
I can't find the option to enable the stream_realip_module module for www/nginx.
I can see it in www/nginx-devel at https://github.com/freebsd/freebsd-ports/commit/261d439fb2143c3fd588d175b5db223c77e77adb but not in www/nginx.

Could you please explain, am I missing something or is it really missing? and is it possible to add (or rather enable by default) in the latter case?

Thanks!!
Comment 1 kulikov.a 2023-02-22 07:46:13 UTC 
Created attachment 240321 [details]
Possible Makefile patch
Comment 2 kulikov.a 2023-02-22 07:47:07 UTC 
Created attachment 240322 [details]
Possible description patch
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2023-03-05 19:32:38 UTC 
Sorry for the delay. I will have a look
Comment 4 kulikov.a 2023-03-10 14:20:16 UTC 
(In reply to Jochen Neumeister from comment #3)
Thanks a lot! really missing this..
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-03-26 16:08:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=427a28cd6ad02fd22de2d8ebaf509c397030a72a

commit 427a28cd6ad02fd22de2d8ebaf509c397030a72a
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2023-03-26 16:05:31 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2023-03-26 16:07:46 +0000

    www/nginx: Add STREAM_REALIP knob for the ngx_stream_realip module.

    Also, create STREAMGRP group for stream-specific modules.

    PR:     267112
    Sponsored by:   Netzkommune GmbH

 www/nginx/Makefile              | 24 ++++++++++++++++++------
 www/nginx/Makefile.options.desc |  1 +
 2 files changed, 19 insertions(+), 6 deletions(-)
Comment 6 kulikov.a 2023-03-26 17:06:08 UTC 
Thanks a lot