Bug 267142 - net/samba413: Mark DEPRECATED and set EXPIRATION_DATE
Summary: net/samba413: Mark DEPRECATED and set EXPIRATION_DATE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yasuhiro Kimura
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-10-17 06:07 UTC by Yasuhiro Kimura
Modified: 2023-11-18 00:32 UTC (History)
7 users (show)

See Also:
yasu: maintainer-feedback-


Attachments
Patch file (1022 bytes, patch)
2022-10-17 06:07 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (1.07 KB, patch)
2023-09-10 14:25 UTC, Yasuhiro Kimura
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2022-10-17 06:07:09 UTC
Created attachment 237393 [details]
Patch file

Samba 4.13 has already reached it EoL on March 21, 2022 and supported version of Samba (net/samba416) is added to ports tree now. So there is no reason to keep EoLed version any more.
Comment 1 dewayne 2022-10-17 22:16:55 UTC
(In reply to Yasuhiro Kimura from comment #0)
Unfortunately SAMBA is used as both a means to authenticate users and provide file services.  SAMBA 4.14 made large changes to its VFS (enhancing functionality for LINUX users) which created a significant support effort for those maintaining/supporting SAMBA.  It appears from the large number of patches to the FreeBSD version that we (the FreeBSD users of SAMBA) are increasingly deviating from the upstream supported version - the FreeBSD user-base has provided patches to 4.13 that address later vulnerabilities.

SAMBA is used by the community to provide:
- Active Directory functionality
- File Services either as a 
-   standalone (simple password) or as a 
-   client of AD.
Many uses customise how SAMBA is built and used; and this requires iterative refinement to enable SAMBA to work correctly for supported versions of FreeBSD.

At this point SAMBA 4.16 is going though some refinement and only works for FreeBSD 13.1+  Refer https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263874 

I would suggest that SAMBA4.13 be deprecated at or after FreeBSD 12.* has reached EOL or if sufficient users have stated that the main SAMBA functionality operates correctly on FreeBSD 12, which likely will mean additional patches. (I don't know the status of FreeBSD 11 schedule).

In my case I use the three uses of SAMBA: AD, fileserver using AD, and as a standalone fileserver on 12.4 (Prerelease) within jails, a slight deviation from the norm, supporting 30 windows users.
Comment 2 Michael Osipov 2022-10-18 08:32:03 UTC
(In reply to dewayne from comment #1)

I fully agree with this. I would even say that those patches need to be upstreamed otherwise Samba is basically doomed on FreeBSD. The effort of patch will be harder and harder.

I don't know what it takes to backport missing features from 13 to 12, but it seems it is critical for many.
Comment 3 dewayne 2022-10-19 02:41:05 UTC
(In reply to Michael Osipov from comment #2)
I don't think its doomed as it has been this way for some time, though it does have a higher dependence on Timur (in particular) and others for ongoing support on FreeBSD.  Please refer to 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263874 comment 68 :)

This isn't necessarily a bad situation but it would be MUCH better if the enhancements to SAMBA weren't so strongly geared toward LINUX (internal).  There is a SAMBA developer or two that has gone to the effort of installing FreeBSD to  resolve/assist with complex FreeBSD-specific issues.  You'd need to review SAMBA's mail archives to appreciate their view, especially as SAMBA also includes DNS and LDAP development/support. I've used SAMBA since 2.2.8, but I haven't written C since ~1990 so I'm reliant on the community.
Comment 4 Timur I. Bakeyev freebsd_committer freebsd_triage 2022-10-25 21:52:17 UTC
While this is expected thing to happen as other people pointed out we still need 4.13 around, as 4.16 isn't mature enough yet and doesn't support older than 13.1 versions of FreeBSD.
Comment 5 Graham Perrin 2023-08-20 18:14:38 UTC
(In reply to Timur I. Bakeyev from comment #4)

> … 4.16 isn't mature enough …

Please, what's the current situation? 

Cross-reference: <https://old.reddit.com/r/freebsd/comments/15vz9j1/-/jwz93ld/>
Comment 6 Yasuhiro Kimura freebsd_committer freebsd_triage 2023-09-10 14:25:20 UTC
Created attachment 244748 [details]
Updated patch file

Set EXPIRATION_DATE to December 31, 2023, the EoL day of FreeBSD 12.
Comment 7 Michael Osipov 2023-09-11 06:39:16 UTC
(In reply to Yasuhiro Kimura from comment #6)

This date isn't appropriate. Given that 4.16 is already obsolete, nothing newer is in the ports tree which can be battlet-tested, I would expect that 4.13 would remain until at least 2024-06-30 in the ports tree.
Comment 8 Yasuhiro Kimura freebsd_committer freebsd_triage 2023-11-18 00:13:00 UTC
Maintainer timeout. Take.
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-11-18 00:30:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7af49901cef3d240ca68a244bfba4b976d807e4c

commit 7af49901cef3d240ca68a244bfba4b976d807e4c
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2022-10-17 06:02:43 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2023-11-18 00:26:25 +0000

    net/samba413: Mark DEPRECATED and set EXPIRATION_DATE

    Samba 4.13 has already reached its EoL on March 21, 2022. The main
    reason this port isn't removed yet is that Samba 4.16 (net/samba416)
    doesn't work with FreeBSD 12. So mark DEPRECATED and set
    EXPIRATION_DATE to December 31, 2023, the EoL day of FreeBSD 12.

    PR:             267142
    Approved by:    maintainer timeout

 net/samba413/Makefile | 3 +++
 1 file changed, 3 insertions(+)