Bug 267152 - security/gnupg: Update to 2.3.8
Summary: security/gnupg: Update to 2.3.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adriaan de Groot
URL: https://lists.gnupg.org/pipermail/gnu...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-10-17 15:53 UTC by Herbert J. Skuhra
Modified: 2022-11-19 01:41 UTC (History)
6 users (show)

See Also:
adridg: maintainer-feedback+


Attachments
Patch Update gnupg 2.3.8 (4.33 KB, patch)
2022-10-17 15:53 UTC, Herbert J. Skuhra
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Herbert J. Skuhra 2022-10-17 15:53:10 UTC
Created attachment 237408 [details]
Patch Update gnupg 2.3.8

The attached patch updates security/gnupg to 2.3.8.
Comment 1 Dennis Clarke 2022-10-24 06:38:47 UTC
I just tested this and it seems to work just fine. 

phobos# 
phobos# uname -apKU
FreeBSD phobos 14.0-CURRENT FreeBSD 14.0-CURRENT #14 main-n258340-497cdf9673e: Sun Oct  2 09:51:14 GMT 2022     root@phobos:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 amd64 1400072 1400072
phobos# pwd
/usr/ports/security/gnupg
phobos# ./work/gnupg-2.3.8/g10/gpg --version
gpg (GnuPG) 2.3.8
libgcrypt 1.9.4
Copyright (C) 2021 Free Software Foundation, Inc.
License GNU GPL-3.0-or-later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: /root/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
        CAMELLIA128, CAMELLIA192, CAMELLIA256
AEAD: EAX, OCB
Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2
phobos# 

The test suite results look perfectly clean.


-- 
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional
Comment 2 Adriaan de Groot freebsd_committer freebsd_triage 2022-11-04 21:34:30 UTC
diizzy@, can you pick this one up as well? It looks sensible at first glance, Dennis has tested, and I just don't have time to chase it.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-11-05 00:04:22 UTC
(In reply to Adriaan de Groot from comment #2)
I'll give it a go, it'll take a few days due to my buildbox having a few things queued up.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-11-06 10:49:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=142c06a26e0fb9293c1614890a1bb5fe04072240

commit 142c06a26e0fb9293c1614890a1bb5fe04072240
Author:     Herbert J. Skuhra <herbert@gojira.at>
AuthorDate: 2022-11-06 08:26:36 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-11-06 10:46:51 +0000

    security/gnupg: Update to 2.3.8

    Changelog:
    https://lists.gnupg.org/pipermail/gnupg-announce/2022q4/000476.html

    Some additional changes to submitted patch:
    - Change PORTVERSION to DISTVERSION
    - Generate patch using "make makepatch"
    - Remove obsolete configure switch

    PR:             267152
    Reviewed by:    adridg (maintainer)
    Tested by:      Dennis Clarke <dclarke@blastwave.org>

 security/gnupg/Makefile                            |  5 ++--
 security/gnupg/distinfo                            |  6 ++---
 security/gnupg/files/patch-common_homedir.c (gone) | 30 ----------------------
 security/gnupg/files/patch-dirmngr_server.c (new)  | 13 ++++++++++
 .../gnupg/files/patch-tools_gpgconf-comp.c (gone)  | 11 --------
 security/gnupg/pkg-plist                           |  2 ++
 6 files changed, 20 insertions(+), 47 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-11-06 10:51:51 UTC
Committed, thanks
Comment 6 Evilham 2022-11-14 12:19:19 UTC
Hey, was the gpg-agent tested with this? After installing this version any program that uses SSH got stuck waiting for the gpg-agent.

In order to keep using things I had to git revert 142c06a26e0fb9293c1614890a1bb5fe04072240, build security/gnupg with poudriere and install the previous version.

Should I open a new PR for this?
Comment 7 Petteri Valkonen 2022-11-17 13:50:27 UTC
(In reply to Evilham from comment #6)

I was hit by the same bug on 12.3-RELEASE-p9. Rolling back the gnupg package to version 2.3.3_3 from the quarterly tree fixed things for me. Opening a new bug would probably be the prudent thing to do.

FWIW, I had a quick browse around the upstream bug tracker (https://dev.gnupg.org/), but I couldn't find anything related to this.
Comment 8 Tomasz "CeDeROM" CEDRO 2022-11-19 01:41:43 UTC
I have also noticed gpg-agent broken in 2.3.8 :-(

Reported dedicated issue here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267858