Created attachment 237440 [details] starfetch-0.0.2 Description: starfetch is a tool that prints out a scheme of a given constellation and some information about it: its quadrant, its right ascension, its declination, its area and its main stars number. WWW: https://github.com/Haruno19/starfetch/ QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.1-RELEASE, amd64)
====> Running Q/A tests (stage-qa) Warning: Possible REINPLACE_CMD issues: - - REINPLACE_CMD ran, but did not modify file contents: src/starfetch.cpp
(In reply to Nuno Teixeira from comment #1) Hi! > REINPLACE_CMD ran, but did not modify file contents: src/starfetch.cpp This warning is because by default, the value of that variable is /usr/local/share/starfetch/. Therefore, when sed_checked.sh modifies the contents of src/starfetch.cpp, it warns because there is no change. But this warning should disappear when DATADIR is a different path: With the same DATADIR: # make patch $ cat work/reinplace_warnings.txt - - REINPLACE_CMD ran, but did not modify file contents: src/starfetch.cpp $ rg --pcre2 '^string path' work/starfetch-0.0.2/src/starfetch.cpp 26:string path = "/usr/local/share/starfetch/"; With a different DATADIR: # make DATADIR=/tmp/starfetch patch $ test -f 'work/reinplace_warnings.txt'; echo $? 1 $ rg --pcre2 '^string path' work/starfetch-0.0.2/src/starfetch.cpp 26:string path = "/tmp/starfetch/";
(In reply to Jesús Daniel Colmenares Oviedo from comment #2) Ok, I did understand.
0.0.3 is out Sugestions: - switch to MASTER_SITES, since upstream provides static tarball now - switch to DISTVERSION as recomended in Porter's Handook Cheers
Created attachment 237543 [details] starfetch-0.0.3 Description: * Update to 0.0.3 * Switch to DISTVERSION * Switch to MASTER_SITES * Remove patch to res/constellations/crux.json (see pr #19 [1]) * Add new constellations in pkg-plist [1] https://github.com/Haruno19/starfetch/pull/19 ChangeLog: https://github.com/Haruno19/starfetch/releases/tag/0.0.3 * Adding new constellations to starfetch: - Monoceros - Lyra - Canes Venatici QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.1-RELEASE, amd64)
This should be in astro not in games?
Created attachment 237554 [details] starfetch-0.0.3 > This should be in astro not in games? That makes more sense, thank you!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=180c65af41a33abd17046187d74c2e5f6cb77624 commit 180c65af41a33abd17046187d74c2e5f6cb77624 Author: Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org> AuthorDate: 2022-10-23 19:25:53 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-10-23 19:25:53 +0000 astro/starfetch: New port: Command line tool that displays constellations - submitter becomes maintainer Description: starfetch is a tool that prints out a scheme of a given constellation and some information about it: its quadrant, its right ascension, its declination, its area and its main stars number. WWW: https://github.com/Haruno19/starfetch/ PR: 267183 astro/Makefile | 1 + astro/starfetch/Makefile (new) | 29 +++++++++++++++++++++++++++++ astro/starfetch/distinfo (new) | 3 +++ astro/starfetch/pkg-descr (new) | 3 +++ astro/starfetch/pkg-plist (new) | 31 +++++++++++++++++++++++++++++++ 5 files changed, 67 insertions(+)
Committed, thanks!