Bug 267234 - DuckDuckGo search is broken in the FreeBSD Documentation Portal (en)
Summary: DuckDuckGo search is broken in the FreeBSD Documentation Portal (en)
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Website (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sergio Carlavilla Delgado
URL: https://docs.freebsd.org/en/
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-10-21 05:30 UTC by Graham Perrin
Modified: 2022-11-05 13:13 UTC (History)
3 users (show)

See Also:
grahamperrin: maintainer-feedback? (carlavilla)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2022-10-21 05:30:48 UTC 
### Steps

1. <https://docs.freebsd.org/en/>

2. observe the hint in the search field, 

       Search in the articles, books and guides.

3. seek GNATS

### Expected

4. search results for the word in the docs.freebsd.org area

### Actual result

4. <https://duckduckgo.com/?ka=v&kt=v&kh=1&kj=r2&q=GNATS&ia=web> 

      Ugly, evil little creatures. 

----

Incidentally, whilst I could not find what was required with DuckDuckGo, Startpage found phrases such as: 

    GNAT Modified General Public License.
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-10-21 05:44:33 UTC 
… I'm fairly certain that there was a comparable bug report involving DuckDuckGo (or "DDG") in the past – but not for the _new_ documentation portal. 

Maybe the earlier report was for the main www site. 

Unfortunately, I can not find a matching report, so I assume carlavilla@ for this one. 

Assigning to myself, although it's not something that I can fix.
Comment 2 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-10-21 08:21:45 UTC 
It should be noted that https://docs.freebsd.org/en/ has two search boxes:

- one at the top of the page (defined in documentation/themes/beastie/layouts/partials/site-header.html ), which works as expected;

- one in the main page, with the hint "Search in the articles, books and guides." which is indeed broken. It is defined at documentation/themes/beastie/layouts/partials/global-search.html . The definition seems to add ' site:docs.FreeBSD.org' to the query, but for some reason it does not work.
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-10-22 03:24:53 UTC 
(In reply to Lorenzo Salvadore from comment #2)

> - one at the top of the page (defined in 
> documentation/themes/beastie/layouts/partials/site-header.html ), 
> which works as expected; …

Confirmed, working for freebsd.org (not specific to the documentation portal). 

Thanks
Comment 4 Ceri Davies freebsd_committer freebsd_triage 2022-10-29 18:08:43 UTC 
(In reply to Graham Perrin from comment #1)
This commit the one you’re thinking of?  https://cgit.freebsd.org/doc/commit/website/content?id=f595e3118ea1c5e1e39a14f812b30f12709f1b03
Comment 5 Graham Perrin freebsd_committer freebsd_triage 2022-10-29 20:14:29 UTC 
(In reply to Ceri Davies from comment #4)

It didn't look familiar, at first, but it does seem to be a perfect fit for bug 261197 comment 1. Thanks!
Comment 6 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2022-11-05 12:30:27 UTC 
I'll take it.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-11-05 13:10:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=77187a3c40eb09b10c28c4550530442c2f6e221a

commit 77187a3c40eb09b10c28c4550530442c2f6e221a
Author:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
AuthorDate: 2022-11-05 13:08:42 +0000
Commit:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
CommitDate: 2022-11-05 13:08:42 +0000

    Fix global search input

    PR:             267234
    Submitted by:   grahamperrin@

 documentation/themes/beastie/layouts/partials/global-search.html | 4 ++--
 documentation/themes/beastie/layouts/partials/site-header.html   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 8 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2022-11-05 13:13:28 UTC 
Fixed. Thanks and sorry for the delay.