Bug 267326 - x11-toolkits/py-python-xlib: update to 0.31
Summary: x11-toolkits/py-python-xlib: update to 0.31
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL: https://github.com/python-xlib/python...
Keywords:
Depends on:
Blocks: 267408
  Show dependency treegraph
 
Reported: 2022-10-25 07:42 UTC by Eero Hänninen
Modified: 2022-10-29 15:32 UTC (History)
2 users (show)

See Also:


Attachments
x11-toolkits/py-python-xlib update to 0.31 (1.67 KB, patch)
2022-10-25 07:42 UTC, Eero Hänninen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eero Hänninen 2022-10-25 07:42:52 UTC
Created attachment 237606 [details]
x11-toolkits/py-python-xlib update to 0.31

x11-toolkits/py-python-xlib: update to 0.31

Changes:
- Changed mastersite from cheeseshop to github
- Renamed PORTNAME from xlib to python-xlib (reason upstream software name)
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-10-25 12:15:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8022bde02077262bdbe79122a6da6cc5f86f9db6

commit 8022bde02077262bdbe79122a6da6cc5f86f9db6
Author:     Eero Hanninen <fax@nohik.ee>
AuthorDate: 2022-10-25 07:11:05 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-10-25 12:14:09 +0000

    x11-toolkits/py-python-xlib: Update to 0.31

    PR:             267326

 x11-toolkits/py-python-xlib/Makefile | 8 ++++----
 x11-toolkits/py-python-xlib/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2022-10-28 12:37:56 UTC
PORTNAME change broke all consumers e.g.,

$ poudriere bulk -j 131amd64 $(git grep -lF :x11-toolkits/py-python-xlib | sed s,/Makefile,,)
[...]
[00:00:04] Warning: deskutils/py-autokey dependency on x11-toolkits/py-python-xlib@py39 has wrong PKGNAME of 'py39-xlib' but should be 'py39-python-xlib'; Is the dependency missing a @FLAVOR?
[00:00:04] Warning: devel/py-ewmh dependency on x11-toolkits/py-python-xlib@py39 has wrong PKGNAME of 'py39-xlib' but should be 'py39-python-xlib'; Is the dependency missing a @FLAVOR?
[00:00:04] Warning: graphics/py-ueberzug dependency on x11-toolkits/py-python-xlib@py39 has wrong PKGNAME of 'py39-xlib' but should be 'py39-python-xlib'; Is the dependency missing a @FLAVOR?
[00:00:04] Warning: misc/py-PyUserInput dependency on x11-toolkits/py-python-xlib@py39 has wrong PKGNAME of 'py39-xlib' but should be 'py39-python-xlib'; Is the dependency missing a @FLAVOR?
[00:00:04] Warning: x11-wm/chamfer dependency on x11-toolkits/py-python-xlib@py39 has wrong PKGNAME of 'py39-xlib' but should be 'py39-python-xlib'; Is the dependency missing a @FLAVOR?
[00:00:04] Warning: x11/mate-dock-applet dependency on x11-toolkits/py-python-xlib@py39 has wrong PKGNAME of 'py39-xlib' but should be 'py39-python-xlib'; Is the dependency missing a @FLAVOR?
[00:00:04] Warning: x11/py-i3ipc dependency on x11-toolkits/py-python-xlib@py39 has wrong PKGNAME of 'py39-xlib' but should be 'py39-python-xlib'; Is the dependency missing a @FLAVOR?
[...]
[131amd64-default-job-03] Extracting py39-python-xlib-0.31: .......... done
===>   py39-i3ipc-2.2.1 depends on package: py39-xlib>0 - not found
*** Error code 1

https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p0116f5c59197_sf7833196bd/logs/errors/py39-autokey-0.95.10_5.log
https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p0116f5c59197_sf7833196bd/logs/errors/py39-ewmh-0.1.6.log
https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p0116f5c59197_sf7833196bd/logs/errors/py39-ueberzug-18.1.8.log
https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p0116f5c59197_sf7833196bd/logs/errors/py39-PyUserInput-0.1.11.log
https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p0116f5c59197_sf7833196bd/logs/errors/chamfer-s20210622_1.log
https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p0116f5c59197_sf7833196bd/logs/errors/mate-dock-applet-21.10.0.log
https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p0116f5c59197_sf7833196bd/logs/errors/py39-i3ipc-2.2.1.log
Comment 3 Eero Hänninen 2022-10-28 13:22:07 UTC
Reopening this bug.

Before I do some fix or revert for PORTNAME, I have question, which is correct solution?
a) Revert PORTNAME (port upstream still have different name)
b) Request somehow mass change on other ports to fix incorrect dependency name
Comment 4 Jan Beich freebsd_committer freebsd_triage 2022-10-28 14:15:11 UTC
(In reply to Eero Hänninen from comment #3)
> which is correct solution?

Up to Assignee to decide. Alternatively, ask python@ for an advice.

> a) Revert PORTNAME (port upstream still have different name)

See also https://wiki.freebsd.org/Python/PortsPolicy#PORTNAME

Existing py-python-* ports don't remove python from PORTNAME e.g.,

$ fgrep PORTNAME */py-python-*/Makefile
archivers/py-python-lhafile/Makefile:PORTNAME=  python-lhafile                                                                                     
archivers/py-python-lzo/Makefile:PORTNAME=      python-lzo                                                                                         
archivers/py-python-rpm-packaging/Makefile:PORTNAME=    python-rpm-packaging
[...]

In other words, reverting would re-introduce inconsistency between PKGORIGIN and PKGBASE. That can be fixed by renaming x11-toolkits/py-python-xlib to x11-toolkits/py-xlib but it'd break consumers again.

> b) Request somehow mass change on other ports to fix
> incorrect dependency name

Something like the following should be enough and covered by "portmgr blanket"[1].

-		${PYTHON_PKGNAMEPREFIX}xlib>0:x11-toolkits/py-python-xlib@${PY_FLAVOR}
+		${PYTHON_PKGNAMEPREFIX}python-xlib>0:x11-toolkits/py-python-xlib@${PY_FLAVOR}

[1] https://docs.freebsd.org/en/articles/committers-guide/#ports-qa-misc-blanket-approval
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-10-29 15:28:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d602356888859931c80c16a391d6e589cae9b3a6

commit d602356888859931c80c16a391d6e589cae9b3a6
Author:     Li-Wen Hsu <lwhsu@FreeBSD.org>
AuthorDate: 2022-10-29 15:27:27 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-10-29 15:27:27 +0000

    Chase x11-toolkits/py-python-xlib package rename

    PR:             267326

 deskutils/py-autokey/Makefile | 6 +++---
 devel/py-ewmh/Makefile        | 3 ++-
 graphics/py-ueberzug/Makefile | 3 ++-
 misc/py-PyUserInput/Makefile  | 3 ++-
 x11-wm/chamfer/Makefile       | 4 ++--
 x11/mate-dock-applet/Makefile | 3 ++-
 x11/py-i3ipc/Makefile         | 3 ++-
 7 files changed, 15 insertions(+), 10 deletions(-)
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2022-10-29 15:32:10 UTC
Updating *_DEPENDS lines is the more common practice in ports tree.