Bug 267372 - biology/biosig: doesn't recognize ENDINITY
Summary: biology/biosig: doesn't recognize ENDINITY
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Stephen Montgomery-Smith
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-26 18:41 UTC by Stephen Montgomery-Smith
Modified: 2022-10-27 01:57 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+


Attachments
Define __LITTLE_ENDIAN to be _LITTLE_ENDIAN, etc. (1.05 KB, patch)
2022-10-26 18:41 UTC, Stephen Montgomery-Smith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Montgomery-Smith freebsd_committer freebsd_triage 2022-10-26 18:41:13 UTC
Created attachment 237662 [details]
Define __LITTLE_ENDIAN to be _LITTLE_ENDIAN, etc.

If I include biosig-dev.h in source code, I receive a compilation error that ENDIANITY isn't known.  I think it is because it doesn't know the variables __LITTLE_ENDIAN or __BIG_ENDIAN.  My patch fixes this.

I need this so that I can create the math/octave-forge-biosig port.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-26 18:44:59 UTC
Thanks for the patch!

Approved, please commit it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-27 01:46:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8d056b579a483362c97d2aa26b8a33fc7a7ea50b

commit 8d056b579a483362c97d2aa26b8a33fc7a7ea50b
Author:     Stephen Montgomery-Smith <stephen@FreeBSD.org>
AuthorDate: 2022-10-27 01:42:44 +0000
Commit:     Stephen Montgomery-Smith <stephen@FreeBSD.org>
CommitDate: 2022-10-27 01:42:44 +0000

    biology/biosig: Make sure __LITTLE_ENDIAN is defined in include files.

    Bump port revision.

    PR:             267372
    Approved by:    yuri@freebsd.org

 biology/biosig/Makefile                            |  1 +
 biology/biosig/files/patch-biosig4c++_biosig-dev.h | 11 +++++++----
 2 files changed, 8 insertions(+), 4 deletions(-)
Comment 3 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2022-10-27 01:57:33 UTC
Committed.