Bug 267588 - net/wmwave: fix build with -fno-common
Summary: net/wmwave: fix build with -fno-common
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL: https://www.freshports.org/net/wmwave/
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-06 10:38 UTC by Robert Clausecker
Modified: 2023-02-16 11:30 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback-
fuz: merge-quarterly?

Attachments
net/wmwave: fix build with -fno-common (4.24 KB, patch)
2022-11-06 10:38 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-11-06 10:38:17 UTC 
Created attachment 237889 [details]
net/wmwave: fix build with -fno-common

While we are at it:

 - define LICENSE
 - switch to USES=localbase
 - add missing include for errx()
 - replace WWW with one that is still up

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Please MFH if possible.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-11-27 12:18:01 UTC 
maintainer timeout
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-11-27 12:18:13 UTC 
Comment on attachment 237889 [details]
net/wmwave: fix build with -fno-common

maintainer timeout on patch
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-02-09 13:42:28 UTC 
Taking due to maintainer timeout.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-02-14 20:24:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3ed49e6414ed7ec56e9a2d4683ea3114271bcae3

commit 3ed49e6414ed7ec56e9a2d4683ea3114271bcae3
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-02-09 13:44:12 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-02-14 20:18:56 +0000

    net/wmwave: fix build with -fno-common

    While we are at it:

     - define LICENSE
     - switch to USES=localbase
     - add missing include for errx()

    PR:             267588
    MFH:            2023Q1
    Approved by:    build fix blanket, maintainer timeout
    Approved by:    flo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38511

 net/wmwave/Makefile                      | 16 ++++++++--------
 net/wmwave/files/patch-wmgeneral.c (new) | 13 +++++++++++++
 net/wmwave/files/patch-wmgeneral.h (new) | 11 +++++++++++
 net/wmwave/files/patch-wmwave.c          | 22 +++++++++++++++-------
 4 files changed, 47 insertions(+), 15 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-15 19:28:03 UTC 
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f2e79d379443412ef854ddf0b210124a431854ff

commit f2e79d379443412ef854ddf0b210124a431854ff
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-02-09 13:44:12 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-02-15 19:27:10 +0000

    net/wmwave: fix build with -fno-common

    While we are at it:

     - define LICENSE
     - switch to USES=localbase
     - add missing include for errx()

    PR:             267588
    MFH:            2023Q1
    Approved by:    build fix blanket, maintainer timeout
    Approved by:    flo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38511

    (cherry picked from commit 3ed49e6414ed7ec56e9a2d4683ea3114271bcae3)

 net/wmwave/Makefile                      | 16 ++++++++--------
 net/wmwave/files/patch-wmgeneral.c (new) | 13 +++++++++++++
 net/wmwave/files/patch-wmgeneral.h (new) | 11 +++++++++++
 net/wmwave/files/patch-wmwave.c          | 22 +++++++++++++++-------
 4 files changed, 47 insertions(+), 15 deletions(-)