Bug 267810 - www/py-django-hijack:Update to 3.2.4
Summary: www/py-django-hijack:Update to 3.2.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL: https://github.com/django-hijack/djan...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-16 13:49 UTC by Kevin Golding
Modified: 2023-05-25 21:33 UTC (History)
2 users (show)

See Also:
ports: maintainer-feedback+

Attachments
Update www/py-django-hijack to 3.2.4 (1.66 KB, patch)
2022-11-16 13:49 UTC, Kevin Golding 		ports: maintainer-approval+
Details | Diff
Update py-django-hijack to 3.2.5 (2.95 KB, patch)
2022-12-06 15:46 UTC, Kevin Golding 		ports: maintainer-approval+
Details | Diff
Update py-django-hijack to 3.3.0 (2.96 KB, patch)
2023-05-24 14:40 UTC, Kevin Golding 		ports: maintainer-approval+
Details | Diff
Updates www/py-django-hijack to 3.4.1 (2.99 KB, patch)
2023-05-25 09:54 UTC, Kevin Golding 		ports: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Golding 2022-11-16 13:49:44 UTC 
Created attachment 238120 [details]
Update www/py-django-hijack to 3.2.4

Update www/py-django-hijack to 3.2.4

Changes: https://github.com/django-hijack/django-hijack/compare/3.2.1...3.2.4

Poudriere: OK
Comment 1 Kevin Golding 2022-12-06 15:46:10 UTC 
Created attachment 238575 [details]
Update py-django-hijack to 3.2.5

Updates to the since released 3.2.5 instead of 3.2.4

https://github.com/django-hijack/django-hijack/compare/3.2.1...3.2.5
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-02-22 00:18:44 UTC 
Build fails on FreeBSD 13.1 in Poudriere:

=======================<phase: configure      >============================
===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes USER=nobody UID=65534 GID=65534
===>   py39-django-hijack-3.2.5 depends on package: py39-setuptools_scm>0 - found
===>   py39-django-hijack-3.2.5 depends on package: py39-pytest-runner>0 - found
===>   py39-django-hijack-3.2.5 depends on executable: npm - found
===>   py39-django-hijack-3.2.5 depends on executable: msgfmt - found
===>   py39-django-hijack-3.2.5 depends on package: py39-setuptools>=63.1.0 - found
===>   py39-django-hijack-3.2.5 depends on file: /usr/local/bin/python3.9 - found
===>  Configuring for py39-django-hijack-3.2.5
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 67, in <module>
    packages=find_packages(exclude=['test_app']),
NameError: name 'find_packages' is not defined
*** Error code 1

This is likely related to your changed patch:

@@ -27,6 +27,7 @@ Handle the installation by native setuptools to prevent errors like
  setup(
      name="django-hijack",
      use_scm_version=True,
++    packages=find_packages(exclude=['test_app']),
      cmdclass={
          "build": build,
 -        "install": install,

Please fix this issue and resubmit.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-03-23 10:26:43 UTC 
No response from maintainer, giving back to the pool.
Comment 4 Wen Heping freebsd_committer freebsd_triage 2023-05-23 10:08:39 UTC 
The build failed:

===>  Configuring for py39-django-hijack-3.2.5
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 67, in <module>
    packages=find_packages(exclude=['test_app']),
NameError: name 'find_packages' is not defined
*** Error code 1

And upstream released 3.3.0, would you update it and fix the build ?
Comment 5 Kevin Golding 2023-05-24 14:40:24 UTC 
Created attachment 242376 [details]
Update py-django-hijack to 3.3.0

This should fix it, an import got skipped in the earlier patch
Comment 6 Kevin Golding 2023-05-25 09:54:06 UTC 
Created attachment 242391 [details]
Updates www/py-django-hijack to 3.4.1

Latest release
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-05-25 21:32:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8fce294f050b356319fe5a7371ffa1859f0ce531

commit 8fce294f050b356319fe5a7371ffa1859f0ce531
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2023-05-25 21:28:54 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2023-05-25 21:30:55 +0000

    www/py-django-hijack: Update to 3.4.1

    PR:             267810
    Reported by:    maintainer

 www/py-django-hijack/Makefile             |  4 ++--
 www/py-django-hijack/distinfo             | 10 +++++-----
 www/py-django-hijack/files/patch-setup.py | 19 ++++++++++---------
 3 files changed, 17 insertions(+), 16 deletions(-)