Bug 267815 - net-mgmt/smokeping: Fix mismatch version
Summary: net-mgmt/smokeping: Fix mismatch version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-16 16:34 UTC by Gasol Wu
Modified: 2022-11-18 08:01 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rodrigo)

Attachments
patch (1.40 KB, patch)
2022-11-16 16:34 UTC, Gasol Wu 		no flags Details | Diff
webpage screenshot (28.86 KB, image/png)
2022-11-16 16:36 UTC, Gasol Wu 		no flags Details
updated patch (2.15 KB, patch)
2022-11-17 00:42 UTC, Gasol Wu 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gasol Wu 2022-11-16 16:34:50 UTC 
Created attachment 238124 [details]
patch

I have installed the latest version of smokeping via the command `pkg install` and the command `pkg info` says it's 2.8.2. But the smokeping(1) says it's 2.00600 and the templates in web frontend says it's 2.6.0 as string like "Running on SmokePing-2.6.0 by Tobi Oetiker and Niko Tyn"

    # smokeping --version
    2.006000
    # pkg info | grep smokeping
    smokeping-2.8.2_3              Latency logging and graphing system

After reviewing Makefile and the sources, I found it's caused by the difference between tarball distributions.
Comment 1 Gasol Wu 2022-11-16 16:36:42 UTC 
Created attachment 238125 [details]
webpage screenshot
Comment 2 Gasol Wu 2022-11-16 16:37:31 UTC 
poudriere testport is running
Comment 3 Rodrigo Osorio freebsd_committer freebsd_triage 2022-11-16 22:44:28 UTC 
Hi Gasol,

Thanks for the report, in fact the version reported by the WebUI is wrong.

I check the github repo and of course found the same error,
but the static archives provided by smokeping project itself
seems to report the correct number.
Maybe the solution is to move to the static archives instead
of changing the version in the sources.

I see how it works this way and gives you a feedback.
Cheers
-- rodrigo
Comment 4 Gasol Wu 2022-11-17 00:42:45 UTC 
Created attachment 238131 [details]
updated patch

Patch updated
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-11-18 08:00:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e1524f9727a7c56986c125f6c070a947923223e

commit 3e1524f9727a7c56986c125f6c070a947923223e
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2022-11-18 07:31:38 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2022-11-18 07:49:34 +0000

    net-mgmt/smokeping: switch from GITHUB to MASTER_SITES

    During the release process, the Smokeping team updates
    the version number displayed in the webUI in the archive
    files but never report this update on the git repo.
    Instead of trying to fix this issue in the port, we move
    back to static archives.

    Apart from version no difference was found on the code.

    Since I'm here, improve the port itself to make linters
    happy.

    PR:             267815
    Reported by:    Gasol Wu <gasol.wu@gmail.com>

 net-mgmt/smokeping/Makefile | 46 ++++++++++++++++++++-------------------------
 net-mgmt/smokeping/distinfo |  6 +++---
 2 files changed, 23 insertions(+), 29 deletions(-)
Comment 7 Rodrigo Osorio freebsd_committer freebsd_triage 2022-11-18 08:01:49 UTC 
Committed with additional port improvements, thanks.