====> Running Q/A tests (stage-qa) Error: /usr/local/bin/workrave is linked to /usr/local/lib/libharfbuzz.so.0 from print/harfbuzz but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libharfbuzz.so:print/harfbuzz Error: /usr/local/bin/workrave is linked to /usr/local/lib/libgdk_pixbuf-2.0.so.0 from graphics/gdk-pixbuf2 but it is not declared as a dependency Warning: you need USE_GNOME+=gdkpixbuf2 (Working on https://lists.freebsd.org/archives/freebsd-ports/2022-January/001398.html, hence DEVELOPER=yes in /etc/make.conf.)
I haven't had a chance to work on updating my ports in a whole, but these are probably easy enough for anyone to add to the port. If anyone does, I'll go ahead and accept the changes.
Created attachment 238136 [details] Add missing library dependencies
Patch has no "make stage" errors, and I minimally tested it by running workrave, seeing it displays a window, and quitting. More testing would probably be better.
Comment on attachment 238136 [details] Add missing library dependencies Patch looks good to me.
(In reply to Naram Qashat from comment #4) Thanks. Can you set maintainer-approval+ on the patch to indicate that?
Comment on attachment 238136 [details] Add missing library dependencies I did when I made the comment, apparently it didn't take because you didn't put my email on it? Not sure what happened there.
Comment on attachment 238136 [details] Add missing library dependencies Added now. Thanks for the reminder.
Comment on attachment 238136 [details] Add missing library dependencies OK, this should do it, then.
^Triage: reporter is committer, assign accordingly.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=764c7201f2a99d2f57c7efcdcc26343cc3250f2b commit 764c7201f2a99d2f57c7efcdcc26343cc3250f2b Author: Naram Qashat <cyberbotx@cyberbotx.com> AuthorDate: 2022-11-22 16:13:20 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-11-23 06:31:10 +0000 x11/workrave: Add missing library PR: 267821 Reported by: pauamma@FreeBSD.org x11/workrave/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Committed, Thanks!
(In reply to Fernando Apesteguía from comment #11) Noting FTR the author was me, not Naram Qashat.