Bug 267883 - cad/PrusaSlicer: fix issue 8299
Summary: cad/PrusaSlicer: fix issue 8299
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Michael Zhilin
URL: https://www.freshports.org/cad/PrusaS...
Keywords: crash
Depends on:
Blocks:
 
Reported: 2022-11-20 20:46 UTC by zielonka michal
Modified: 2022-12-05 13:41 UTC (History)
3 users (show)

See Also:
teodorsigaev: maintainer-feedback+


Attachments
patch fixing 8299 isssue (3.49 KB, patch)
2022-11-20 20:46 UTC, zielonka michal
no flags Details | Diff
patch fixing 8299 isssue + bumping portrevision (3.77 KB, patch)
2022-11-21 12:01 UTC, zielonka michal
no flags Details | Diff
Screenshot: the Details dialogue, for some but not all details (183.86 KB, image/png)
2022-12-03 07:34 UTC, Graham Perrin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description zielonka michal 2022-11-20 20:46:24 UTC
Created attachment 238197 [details]
patch fixing 8299 isssue

I've met situation described in issue: https://github.com/prusa3d/PrusaSlicer/issues/8299.
I've made fix from comment: https://github.com/prusa3d/PrusaSlicer/issues/8299#issuecomment-1236374198.
And it works again. The problem is connected that prusa slicer 2.5.0 has dependency to wx 3.2.0. And the app is crashing when tries set default language.
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-11-21 02:25:15 UTC
Triage: 

* a proper prefix to the summary line for a bug report for a port

* flagging for attention from the maintainer (this flagging is normally 
  automated, if the prefix is given when submitting a report).
Comment 2 Teodor Sigaev 2022-11-21 07:17:10 UTC
Seems, works for me. Suppose, PORTREVISION should be bumped.
Comment 3 zielonka michal 2022-11-21 12:01:06 UTC
Created attachment 238210 [details]
patch fixing 8299 isssue + bumping portrevision

@teodorsigaev I've added PORTREVISION=1
Comment 4 Teodor Sigaev 2022-11-21 13:04:17 UTC
Comment on attachment 238210 [details]
patch fixing 8299 isssue + bumping portrevision

Seems ok
Comment 5 Teodor Sigaev 2022-11-21 13:05:42 UTC
(In reply to teodorsigaev@gmail.com from comment #4)
Hm, bugzilla doesn't allow to change attachment flags to set maintainer-approval+
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-12-03 07:06:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f788ec6d2e3641a01e2207a207a797463a72b28a

commit f788ec6d2e3641a01e2207a207a797463a72b28a
Author:     Michael Zhilin <mizhka@FreeBSD.org>
AuthorDate: 2022-12-03 06:59:56 +0000
Commit:     Michael Zhilin <mizhka@FreeBSD.org>
CommitDate: 2022-12-03 07:05:30 +0000

    cad/PrusaSlicer: backport fix from upstream

     - The app is crashing when tries to set default language.
     - Make QA tests a bit more happy

    PR: 267883
    Submitted by: michal.zielonka.8001@gmail.com

 cad/PrusaSlicer/Makefile                           | 21 ++++++++++----
 .../files/patch-src_slic3r_GUI_GUI__App.cpp        | 32 ++++++++++++++++++++--
 2 files changed, 46 insertions(+), 7 deletions(-)
Comment 7 Michael Zhilin freebsd_committer freebsd_triage 2022-12-03 07:08:15 UTC
Thanks!
Comment 8 Graham Perrin freebsd_committer freebsd_triage 2022-12-03 07:34:21 UTC
Created attachment 238497 [details]
Screenshot: the Details dialogue, for some but not all details

Retrospective:

(In reply to teodorsigaev@gmail.com from comment #5)

> … change attachment flags to set maintainer-approval+

The Details dialogue – with    &action=edit    in the URL – initially 
presents not all details for the purpose of edition. 

There's a further step, inline with the description, for a second step 
(edit details) through which _additional_ details can be edited. 

At step one, I see a flagging area, to the right of the commenting 
area (screenshot attached). As less privileged user, do you see this?
Comment 9 Teodor Sigaev 2022-12-05 13:41:20 UTC
(In reply to Graham Perrin from comment #8)
> At step one, I see a flagging area, to the right of the commenting 
> area (screenshot attached). As less privileged user, do you see this?

Yes, I see. But if change this and press submit button nothing happens - flags isn't changed