IBM's Java Development Kit for Linux. :) Thanx
Some suggestions: * Name this port linux-ibm-jdk13 because IBM has 1.1 and 1.2 JDK's too. * Tell the user to download the distfile from http://www6.software.ibm.com/dl/dklx130/dklx130-p, that's a direct link to the download page. I wonder if this JDK actually works under FreeBSD 4.x. I'm installing it on a fresh FreeBSD 4.3-RELEASE box as we speak.
Yup. This port actually installs the IBM JDK 1.3.0. It also registers the port with javavmwrapper. Pretty kewl. The version output after installing this JDK: > javavm -version JIT cannot get processor_num. Assuming SMP... java version "1.3.0" Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.0) Classic VM (build 1.3.0, J2RE 1.3.0 IBM build cx130-20010329 (JIT enabled: jitc)) Okay, basically it seems to run. I see no trouble in submitting this port after the given suggestions have been incorporated. We may have to improve matters afterwards, but at least we'll have an IBM JDK port B-) Great work, Hye-Shik! -- Ernst
Okay, I tested this JDK and it seems to work, at least with non-graphical applications. I tested it with Ant and javadoc, and it runs without any big problems. Only things I noticed are: * When starting 'java' the program gives a warning about not being able to determine the number of processors. This looks like a linuxulator 'problem'. Should I submit this as a new PR ? * When running a program, the program doesn't return to the command line. It doesn't use a lot of processor time either, and Ctrl-C does stop the program. Haven't looked into this yet. My suggestion: Make sure the name of the port is more specific (for example 'linux-ibm-jdk1.3' instead of 'ibm-jdk'), make the name of the install directory more specific ('linux-ibm-jdk1.3.0' instead of 'ibmjdk1.3.0') and then submit this port for inclusion in the tree. It's good enough for testing and further improvement IMO. -- Ernst
Hi! I was busy for a while for moving company. so sorry. :) According as Ernst's advice, I renamed the port to linux-ibm-jdk, and changed default target prefix to ${PREFIX}/linux-ibm-jdk1.3 thanx very much! :D and added some messages about linprocfs according to Maxim's. Here is the patch (from previous PR ports/26793): diff -ruN ibm-jdk/Makefile linux-ibm-jdk/Makefile --- ibm-jdk/Makefile Fri May 11 17:32:17 2001 +++ linux-ibm-jdk/Makefile Fri May 11 17:38:20 2001 @@ -1,4 +1,4 @@ -# New ports collection makefile for: ibm-jdk +# New ports collection makefile for: linux-ibm-jdk # Date created: 22 April 2001 # Whom: Hye-Shik Chang <perky@python.or.kr> # @@ -9,23 +9,23 @@ PORTVERSION= ${JDK_VERSION} CATEGORIES= java MASTER_SITES= # -PKGNAMEPREFIX= ibm- +PKGNAMEPREFIX= linux-ibm- DISTNAME= IBMJava2-SDK-13 EXTRACT_SUFX= .tgz MAINTAINER= perky@python.or.kr BUILD_DEPENDS= ${LOCALBASE}/bin/javavm:${PORTSDIR}/java/javavmwrapper -RUN_DEPENDS= ${LINUXBASE}/lib/libc.so.6:${PORTSDIR}/emulators/linux_base \ - ${LOCALBASE}/bin/javavm:${PORTSDIR}/java/javavmwrapper +RUN_DEPENDS= ${LOCALBASE}/bin/javavm:${PORTSDIR}/java/javavmwrapper WRKSRC= ${WRKDIR}/${DISTNAME:S/-SDK//} PLIST_SUB+= TARGET_PREFIX=${TARGET_PREFIX:S/^${PREFIX}\///} NO_BUILD= yes -JDK_VERSION= 1.3.0 +USE_LINUX= yes +JDK_VERSION= 1.3.0 ONLY_FOR_ARCHS= i386 -TARGET_PREFIX?= ${PREFIX}/${PKGNAME:S/-//g} +TARGET_PREFIX?= ${PREFIX}/${PKGBASE}${PORTVERSION} LINUX_SH?= ${LINUXBASE}/bin/sh NO_CDROM= "License doesn\'t allow distribution with fee" @@ -56,6 +56,9 @@ do-install: ${MKDIR} ${TARGET_PREFIX} ${TAR} -C ${WRKSRC} -cf- . | ${TAR} -C ${TARGET_PREFIX} -xpf- - ${LOCALBASE}/bin/registervm "${TARGET_PREFIX}/bin/java # IBM-JDK${JDK_VERSION}" + ${LOCALBASE}/bin/registervm "${TARGET_PREFIX}/bin/java # IBM-JDK${PORTVERSION}" + +post-install: + @${CAT} ${PKGMESSAGE} .include <bsd.port.post.mk> diff -ruN ibm-jdk/pkg-message linux-ibm-jdk/pkg-message --- ibm-jdk/pkg-message Thu Jan 1 09:00:00 1970 +++ linux-ibm-jdk/pkg-message Fri May 11 17:15:38 2001 @@ -0,0 +1,7 @@ +============================================================= +This port will takes cpuinfo from linux emulation's procfs. +You may want to add below one line into /etc/fstab for +turning it on. + + linprocfs /compat/linux/proc linprocfs rw 0 0 +============================================================= -------------------------------- Hye-Shik Chang, a.k.a. "Perky" Mechatronics, Yonsei University, Korea Public Key: http://openlook.org/pgp.txt PGP Fingerprint : 115C CF2F D90D 8AFE F45B 0356 21DA 398B 6474 11EA ------------------------------------------------- DreamWiz Free Mail @ http://www.dreamwiz.com/ DreamSearch Click the world!!! http://search.dreamwiz.com/
Hi Hye-Shik, > I was busy for a while for moving company. so sorry. :) No problem. Glad to see your `face' again :) > According as Ernst's advice, I renamed the port to linux-ibm-jdk, > and changed default target prefix to ${PREFIX}/linux-ibm-jdk1.3 > thanx very much! :D > and added some messages about linprocfs according to Maxim's. Kewl. The diff looks good, except for these points: [1] I suggest using the link to the download page as I suggested in a previous reply to your PR (see the audit trail), it's: * http://www6.software.ibm.com/dl/dklx130/dklx130-p [2] Improve the message about linprocfs: > +============================================================= > +This port will takes cpuinfo from linux emulation's procfs. > +You may want to add below one line into /etc/fstab for > +turning it on. > + > + linprocfs /compat/linux/proc linprocfs rw 0 0 > +============================================================= Suggestion: "This Java VM will attempt to detect the number of processors by taking cpuinfo from linux's procfs. You may want to install the Linux emulation procfs filesystem. You may do so by adding the following line to your /etc/fstab file: linprocfs /compat/linux/proc linprocfs rw 0 0" Thanks again! Ernst -- Ernst de Haan Java Architect Jollem Information Technology "Come to me all who are weary and burdened and I will give you rest" -- Jesus Christ
Hi, Ernst. >No problem. Glad to see your `face' again :) Thank you. :-) >[1] I suggest using the link to the download page as I suggested in a previous > reply to your PR (see the audit trail), it's: > > * http://www6.software.ibm.com/dl/dklx130/dklx130-p I think that url can be changed sometime by ibm's web service layout policy or their load balancing. so, I'm sorry but it seems to be more suitable for freebsd port http://www.ibm.com/developerworks/java/jdk/linux130. > >[2] Improve the message about linprocfs: > > Suggestion: > > "This Java VM will attempt to detect the number of processors by taking > cpuinfo from linux's procfs. You may want to install the Linux > emulation procfs filesystem. You may do so by adding the following > line to your /etc/fstab file: > > linprocfs /compat/linux/proc linprocfs rw 0 0" > Thank you for your favor! :) Since I'm not good at english, I am always in difficult when write describe or messages, therefore yours was very helpful. and I uploaded final(maybe?) port shar. You can download it from http://www3.kr.freebsd.org/~perky/distfiles/linux-ibm-jdk.txt have a nice day! -------------------------------- Hye-Shik Chang, a.k.a. "Perky" Mechatronics, Yonsei University, Korea Public Key: http://openlook.org/pgp.txt PGP Fingerprint : 115C CF2F D90D 8AFE F45B 0356 21DA 398B 6474 11EA ------------------------------------------------- DreamWiz Free Mail @ http://www.dreamwiz.com/ DreamSearch Click the world!!! http://search.dreamwiz.com/
> >[1] I suggest using the link to the download page as I suggested in a previous > > reply to your PR (see the audit trail), it's: > > > > * http://www6.software.ibm.com/dl/dklx130/dklx130-p Okay, then perhaps include both, because this link may allow people to find the file minutes earlier. What's the disadvantage? > I think that url can be changed sometime by ibm's web service > layout policy or their load balancing. so, I'm sorry but it seems to > be more suitable for freebsd port > http://www.ibm.com/developerworks/java/jdk/linux130. You may be right about the load balancing and/or layout policies. And yet, if the link is changed, we could just change the port :) > and I uploaded final(maybe?) port shar. You can download it from > http://www3.kr.freebsd.org/~perky/distfiles/linux-ibm-jdk.txt Downloaded it. And found that the name of the port is "linux-ibm-jdk" although IBM provides several JDKs for Linux, including 1.1 and 1.2 JDKs. Perhaps "linux-ibm-jdk13" is a better name? This is in this respect analog to the name of the other non-IBM Linux JDKs, which are named "linux-jdk" and "linux-jdk13". My suggestion would be to change the names of these ports as well, but I'll submit a new PR for that. Oh, and I must say the Makefile looks very professional! Gonna have to look at it to improve my own ports a bit =) Ernst -- Ernst de Haan Java Architect Jollem Information Technology "Come to me all who are weary and burdened and I will give you rest" -- Jesus Christ
State Changed From-To: open->closed Committed, with additions from the PR. Thanks to all.