Bug 267931 - x11-wm/jwm: Update to 2.4.3
Summary: x11-wm/jwm: Update to 2.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://joewing.net/projects/jwm/
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-11-22 19:18 UTC by John Grafton
Modified: 2022-11-24 16:08 UTC (History)
1 user (show)

See Also:


Attachments
patch to update x11-wm/jwm to 2.4.3 (1.16 KB, patch)
2022-11-22 19:18 UTC, John Grafton
no flags Details | Diff
patch to update x11-wm/jwm to 2.4.3 (2.11 KB, patch)
2022-11-23 20:09 UTC, John Grafton
john.grafton: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Grafton 2022-11-22 19:18:19 UTC
Created attachment 238261 [details]
patch to update x11-wm/jwm to 2.4.3

Update x11-wm/jwm to 2.4.3

Changes this release:
  http://joewing.net/projects/jwm/release-2.4.html
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-11-22 19:18:19 UTC
Maintainer informed via mail
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-23 06:48:41 UTC
Q/A: PORTREVISION should be deleted. NO NEED to update a new patch.

I'm assuming you are maintainer. Would you mind setting +maintainer-flag in the attachment?

Thanks!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-23 10:39:21 UTC
Fails to build in poudriere:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%DATADIR%%/jwm-red.svg
Error: Orphaned: share/locale/lt/LC_MESSAGES/jwm.mo
Error: Orphaned: share/locale/tr/LC_MESSAGES/jwm.mo
Error: Orphaned: share/locale/uk/LC_MESSAGES/jwm.mo
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Would you have a look?
Comment 4 John Grafton 2022-11-23 20:09:06 UTC
Created attachment 238282 [details]
patch to update x11-wm/jwm to 2.4.3
Comment 5 John Grafton 2022-11-23 20:10:25 UTC
(In reply to Fernando Apesteguía from comment #3)
Ah, thanks!  Patch is updated with fixes.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-24 06:38:50 UTC
(In reply to John Grafton from comment #5)
FATAL: Makefile: [4]: use a tab (not space) after a variable name

No need to update the patch. Just try and use portlint, portclippy and poudriere. They are great tools :-)
Comment 7 John Grafton 2022-11-24 15:59:38 UTC
(In reply to Fernando Apesteguía from comment #6)
Oh, I missed the bit about using `poudriere testport` in the porter's handbook.  I used poudriere bulk without -t to build the port and it didn't throw any errors.  I'll know better next time.  Thanks!  :)
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-24 16:08:36 UTC
Committed,

Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-11-24 16:08:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9253d1d72ab19f596d075f42552af8c5ce552cc7

commit 9253d1d72ab19f596d075f42552af8c5ce552cc7
Author:     John Grafton <john.grafton@runbox.com>
AuthorDate: 2022-11-23 06:51:40 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-11-24 16:03:14 +0000

    x11-wm/jwm: Update to 2.4.3

    ChangeLog: https://joewing.net/projects/jwm/
    New Features

     * Mouse bindings are now configurable
     * Added key bindings
     * Added ~/.config/jwm/jwmrc as the new default location for per-user
       configuration
     * Maximized windows once again have borders and can be resized
     * The placement of window buttons is now configurable
     * Restored automatic tray "autohide" functionality using autohide="on"
     * Added support for CDATA to the XML parser
     * Moved the group and list attributes to the TaskListStyle tag
     * Added key bindings to resize a window from a specific corner or side
     * Add Type tag to Group

    Bug Fixes

     * Don't SetDefaultCursor in AddClientToWindow
     * Use pango to address font fixes
     * Fix for large titles that are centered or right aligned
     * Fix tooltip delay

    Updated Translations

     * Portuguese
     * Portuguese Brazil
     * Turkish
     * Spanish
     * Danish
     * Lithuanian

    Add UPDATING entry due to config changes.

    PR:             267931
    Reported by:    john.grafton@runbox.com (maintainer)

 UPDATING             | 14 ++++++++++++++
 x11-wm/jwm/Makefile  | 35 ++++++++++++++++++-----------------
 x11-wm/jwm/distinfo  |  6 +++---
 x11-wm/jwm/pkg-plist |  4 ++++
 4 files changed, 39 insertions(+), 20 deletions(-)