Bug 268036 - devel/py-proxmoxer: Update to 2.0.0
Summary: devel/py-proxmoxer: Update to 2.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/proxmoxer/proxmoxe...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-28 10:13 UTC by Einar Bjarni Halldórsson
Modified: 2022-12-09 11:24 UTC (History)
1 user (show)

See Also:


Attachments
Upgrade devel/py-proxmoxer to version 2.0.0 and add info to UPDATING (2.42 KB, patch)
2022-11-28 10:13 UTC, Einar Bjarni Halldórsson
einar: maintainer-approval+
Details | Diff
Upgrade devel/py-proxmoxer to version 2.0.0 and add info to UPDATING. Remove all tests until re-added upstream (2.75 KB, patch)
2022-12-05 09:31 UTC, Einar Bjarni Halldórsson
einar: maintainer-approval+
Details | Diff
Reformatted patch and removed mention of pytest from UPDATING (3.05 KB, patch)
2022-12-08 09:12 UTC, Einar Bjarni Halldórsson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Einar Bjarni Halldórsson 2022-11-28 10:13:35 UTC
Created attachment 238395 [details]
Upgrade devel/py-proxmoxer to version 2.0.0 and add info to UPDATING

Upgrade devel/py-proxmoxer to latest version 2.0.0
    
*   Improvement (all): Convert testing framework to use pytest (John Hollowell)
*  Improvement (all): Remove Python 2.x support (minimum version of 3.7) (John Hollowell)
*  Improvement (all): Refactor code to Python 3 standards (John Hollowell)
*  Bugfix (all): Remove None values from request data and params (Kristian Heljas)
*  Addition (tools): Added Task tools (John Hollowell)
*  Bugfix (all): Allow specifying resource_id as 0 (John Bergvall)
*  Improvement (all): Remove ProxmoxResourceBase (John Hollowell)
*  Bugfix (all): Add platform detection before using shlex functions (Kevin Boyd)
*  Improvement (https): Added path_prefix argument which is appended after the root of the URL (before api2/) (John Hollowell)
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 19:48:49 UTC
According to UPDATING, USE_PYTHON+=pytest should be used then, "# do-test:" comment deleted (since pytest create a "do-test" himself) and maybe re-check TEST_DEPENDS list and test/evaluate if they are needed.
Comment 2 Einar Bjarni Halldórsson 2022-12-05 09:31:58 UTC
Created attachment 238530 [details]
Upgrade devel/py-proxmoxer to version 2.0.0 and add info to UPDATING. Remove all tests until re-added upstream

New patch to upgrade to version 2.0.0

Removed all test related config. Upstream doesn't package tests/ directory in pypi anymore (and hasn't for a long time).

I'm working on getting tests added again to the pypi distribution, but until then, remove it and get the new version out.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-08 08:41:25 UTC
What about changing Update:

(...)
Testing changed to pytest ==> Testing changed to pytest (work in progress)
(...)

So users know that test is being worked?
Comment 4 Einar Bjarni Halldórsson 2022-12-08 09:12:50 UTC
Created attachment 238624 [details]
Reformatted patch and removed mention of pytest from UPDATING
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-12-09 11:24:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c8753eb9c736c8876a2c00aa200e6a2b5453986

commit 8c8753eb9c736c8876a2c00aa200e6a2b5453986
Author:     Einar Bjarni Halldórsson <einar@isnic.is>
AuthorDate: 2022-12-09 11:18:24 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-09 11:23:09 +0000

    devel/py-proxmoxer: Update to 2.0.0

     - add UPDATING notes
     - pytest testunit in progress

    ChangeLog:
    https://github.com/proxmoxer/proxmoxer/blob/develop/CHANGELOG.md

    PR:             268036

 UPDATING                    | 23 +++++++++++++++++++++++
 devel/py-proxmoxer/Makefile | 10 ++--------
 devel/py-proxmoxer/distinfo |  6 +++---
 3 files changed, 28 insertions(+), 11 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-09 11:24:34 UTC
Committed, thanks!