Bug 268094 - cad/freecad: fix desktop integration, add missing deps
Summary: cad/freecad: fix desktop integration, add missing deps
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Christoph Moench-Tegeder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-01 10:01 UTC by Max Brazhnikov
Modified: 2023-01-02 13:22 UTC (History)
0 users

See Also:
makc: maintainer-feedback?


Attachments
patch (71.17 KB, patch)
2022-12-01 10:01 UTC, Max Brazhnikov
no flags Details | Diff
patch v2 (4.95 KB, patch)
2022-12-14 21:22 UTC, Max Brazhnikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Brazhnikov freebsd_committer freebsd_triage 2022-12-01 10:01:21 UTC
Created attachment 238471 [details]
patch

Fix desktop integration by installing shared files to the standard path.
Also, add missing dependencies and use latest hdf5 - FreeCAD links to hdf5-1.12 if both hdf5-1.10 and hdf5-1.12 are installed.
Comment 1 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2022-12-08 22:05:46 UTC
FreeCAD picks up both hdf - one via fr-med, one via vtk9 and in the past, sticking to the one from fr-med was the better choice, so we're not changing that until we've cleaned up the hdf5 mess at large. Also, how is that dependency missing, and the patch drop a file post-install without documentation. And I don't get how desktops require moving half the port around (I guess that's on me, as I stopped caring about desktops 20 years ago and use fvwm).
Just so that nobody gets ideas.
Comment 2 Max Brazhnikov freebsd_committer freebsd_triage 2022-12-14 21:22:35 UTC
Created attachment 238797 [details]
patch v2

ok, second try with minimal changes to the port:

- Install XDG files to the standard path, where DE can find them
- Install freecad-thumbnailer
- Add missing USES
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2022-12-29 12:06:16 UTC
Christoph, are you ok with the second patch?
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-01-02 12:15:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=763124badcba812eb72f72397357062296d7bd72

commit 763124badcba812eb72f72397357062296d7bd72
Author:     Max Brazhnikov <makc@FreeBSD.org>
AuthorDate: 2023-01-02 12:10:02 +0000
Commit:     Max Brazhnikov <makc@FreeBSD.org>
CommitDate: 2023-01-02 12:11:11 +0000

    cad/freecad: fix desktop integration

    - Install XDG files to the standard path, where DE can find them
    - Install freecad-thumbnailer
    - Add missing USES

    PR:             268094
    Approved by:    maintainer timeout (18 days)

 cad/freecad/Makefile  | 16 ++++++++++++----
 cad/freecad/pkg-plist | 27 +++++++++++++++------------
 2 files changed, 27 insertions(+), 16 deletions(-)