Bug 268374 - x11-fonts/dejavu: font config files contain invalid paths in comments
Summary: x11-fonts/dejavu: font config files contain invalid paths in comments
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-14 15:01 UTC by Michael Osipov
Modified: 2024-05-09 07:14 UTC (History)
5 users (show)

See Also:
michael.osipov: maintainer-feedback-

Attachments
Git-formatted patch (1.22 KB, patch)
2023-07-05 09:46 UTC, Michael Osipov 		no flags Details | Diff
Git-formatted patch (1.49 KB, patch)
2023-08-14 08:59 UTC, Michael Osipov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2022-12-14 15:01:48 UTC 
PREFIX/LOCALBASE have not been applied in post-patch:
root@deblndw013x2j:/usr/local/etc/fonts
# grep -r /etc/ conf.avail/
conf.avail/57-dejavu-sans.conf:<!-- /etc/fonts/conf.d/57-dejavu-sans.conf
conf.avail/20-unhint-small-dejavu-serif.conf:  <!--  /etc/fonts/conf.d/20-unhint-small-dejavu-serif.conf
conf.avail/57-dejavu-sans-mono.conf:<!-- /etc/fonts/conf.d/57-dejavu-sans-mono.conf
conf.avail/20-unhint-small-dejavu-sans.conf:  <!--  /etc/fonts/conf.d/20-unhint-small-dejavu-sans.conf
conf.avail/57-dejavu-serif.conf:<!-- /etc/fonts/conf.d/57-dejavu-serif.conf
conf.avail/20-unhint-small-dejavu-sans-mono.conf:  <!--  /etc/fonts/conf.d/20-unhint-small-dejavu-sans-mono.conf

I'd expect the comment to say: /usr/local/etc/fonts/conf.d/{conf-file}
Comment 1 Michael Osipov 2023-01-09 11:16:00 UTC 
Can provide a patch
Comment 2 Michael Osipov 2023-07-05 09:46:00 UTC 
Created attachment 243262 [details]
Git-formatted patch

Here is a quality patch
Comment 3 Michael Osipov 2023-08-14 08:59:59 UTC 
Created attachment 244090 [details]
Git-formatted patch
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2023-09-12 06:39:29 UTC 
sunpoet, can you have a look?
Comment 5 Michael Osipov 2023-09-22 09:21:58 UTC 
Guys, don't forget: 10 days left until next quarterly.
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-09-30 00:24:24 UTC 
IMHO, it is not needed to fix a comment. If anyone really cares about it, I'd rather remove it instead of fixing the path since it does not provide any extra information
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-30 00:57:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dc16c9a9a5abf38e8d5f44d5352d1df520673411

commit dc16c9a9a5abf38e8d5f44d5352d1df520673411
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2023-09-30 00:33:28 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2023-09-30 00:46:33 +0000

    x11-fonts/dejavu: Remove incorrect path from comment

    - Bump PORTREVISION for package change

    PR:             268374
    Reported by:    Michael Osipov <michael.osipov@siemens.com>

 x11-fonts/dejavu/Makefile                                     |  2 +-
 ...tch-fontconfig-20-unhint-small-dejavu-sans-mono.conf (new) | 11 +++++++++++
 .../patch-fontconfig-20-unhint-small-dejavu-sans.conf (new)   | 11 +++++++++++
 .../patch-fontconfig-20-unhint-small-dejavu-serif.conf (new)  | 11 +++++++++++
 .../files/patch-fontconfig-57-dejavu-sans-mono.conf (new)     | 10 ++++++++++
 .../dejavu/files/patch-fontconfig-57-dejavu-sans.conf (new)   | 10 ++++++++++
 .../dejavu/files/patch-fontconfig-57-dejavu-serif.conf (new)  | 10 ++++++++++
 7 files changed, 64 insertions(+), 1 deletion(-)
Comment 8 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-09-30 01:10:32 UTC 
Committed. Thanks!
Comment 9 Koichiro Iwao freebsd_committer freebsd_triage 2023-10-01 13:19:02 UTC 
(In reply to Michael Osipov from comment #5)
I don't think the border of quarterly isn't an issue. We can whenever do cherry-pick to the quarterly branch if the fix is required for the current quarter. Fixes are not only shipped at the beginning of the quarter.
Comment 10 Michael Osipov 2023-10-01 16:18:01 UTC 
(In reply to Koichiro Iwao from comment #9)

That is true, but we should just avoid unnecessary work, if possible.
Comment 11 Noncongo 2024-05-09 07:14:01 UTC 
MARKED AS SPAM