Bug 268419 - x11-themes/kde-icons-black-and-white: WWW: www.kde-look.org no longer found, use store.kde.org
Summary: x11-themes/kde-icons-black-and-white: WWW: www.kde-look.org no longer found, ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL: https://store.kde.org/p/1120904
Keywords: easy
Depends on:
Blocks:
 
Reported: 2022-12-16 20:23 UTC by Graham Perrin
Modified: 2023-02-14 21:51 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback+


Attachments
git diff for x11-themes/kde-icons-black-and-white (667 bytes, patch)
2022-12-16 23:59 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2022-12-16 20:23:43 UTC
<https://www.kde-look.org/content/show.php?content=24645> server not found. 

% route show www.kde-look.org
route: bad address: www.kde-look.org
%
Comment 1 Chris Hutchinson 2022-12-16 23:59:07 UTC
Created attachment 238851 [details]
git diff for x11-themes/kde-icons-black-and-white

When I updated this port a couple weeks ago I tested
the WWW and it worked. Today, www.kde-look.org has
no IP. But kde-look.org *does*. However, kde-look.org
is a REDIR to store.kde.org.

The patch attached to this pr(1) acknowledges the above.

Thanks, Graham! :-)

--chris
Comment 2 Chris Hutchinson 2022-12-17 00:03:33 UTC
Keywords: easy, patch, patch-ready, dogfood
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-12-17 08:42:35 UTC
Thanks, 

(In reply to Chris Hutchinson from comment #2)

The 'patch' and 'patch-ready' keywords are deprecated.

Please see <https://bugs.freebsd.org/bugzilla/> (changes, to the right); <https://bugs.freebsd.org/bugzilla/describekeywords.cgi> (updated); <https://wiki.freebsd.org/Bugzilla>.
Comment 4 Chris Hutchinson 2022-12-18 02:02:22 UTC
(In reply to Graham Perrin from comment #3)
Thanks, Graham. :-)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-02-10 14:44:46 UTC
While we are at it, I would like to add

    NO_ARCH= yes

to the port.  Do you approve of this change?
Comment 6 Chris Hutchinson 2023-02-12 01:56:19 UTC
(In reply to Robert Clausecker from comment #5)
Are you providing the patch for your proposed change,
or am I?

In either case, I would approve.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-02-12 09:21:25 UTC
(In reply to Chris Hutchinson from comment #6)

I've just edited into your patch which is planned to be committed with your authorship: https://reviews.freebsd.org/D38521
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-02-14 20:24:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=09a830afdcfce1f0277aea54a57abbf641d51428

commit 09a830afdcfce1f0277aea54a57abbf641d51428
Author:     Chris Hutchinson <portmaster@BSDforge.com>
AuthorDate: 2023-02-10 13:31:04 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-02-14 20:23:41 +0000

    x11-themes/kde-icons-black-and-white: change WWW to less dead site

    The old www.kde-look.org is dead, kde-look.org redirects
    to store.kde.org.  Change WWW to the latter.

    PR:             268419
    Reported by:    grahamperrin
    Approved by:    eduardo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38521

 x11-themes/kde-icons-black-and-white/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2023-02-14 20:28:58 UTC
Committed, thanks.
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2023-02-14 20:29:13 UTC
Committed, thanks.
Comment 11 Chris Hutchinson 2023-02-14 21:51:49 UTC
(In reply to Robert Clausecker from comment #10)
Thanks!