Bug 268504 - tools/test/gpioevents: add support for floating and pull-down pins
Summary: tools/test/gpioevents: add support for floating and pull-down pins
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Emmanuel Vadot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-21 22:07 UTC by Rene Ladan
Modified: 2022-12-29 17:16 UTC (History)
0 users

See Also:


Attachments
gpioevents: add support for pull-down and floating input pins. (3.03 KB, patch)
2022-12-21 22:07 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2022-12-21 22:07:57 UTC
Created attachment 238963 [details]
gpioevents: add support for pull-down and floating input pins.

gpioevents: add support for pull-down and floating input pins.
    
The pin-mode (ft, pd, pu for floating, pull-down, pull-up) is
specified after the intr-config (no, eb, ef, er) for each pin.
    
Tested on my Raspberry Pi 1B.
    
Approved by:    (src committer)
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2022-12-21 22:34:40 UTC
It might be nice to merge this to stable/13 so that it lands in 13.2 ?
Comment 2 Emmanuel Vadot freebsd_committer freebsd_triage 2022-12-22 07:18:04 UTC
LGTM thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-22 09:15:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=453db42291a3179a51b9bf41ca7dbc0a5298bffa

commit 453db42291a3179a51b9bf41ca7dbc0a5298bffa
Author:     Rene Ladan <rene@FreeBSD.org>
AuthorDate: 2022-12-21 21:24:11 +0000
Commit:     Rene Ladan <rene@FreeBSD.org>
CommitDate: 2022-12-22 09:13:59 +0000

    gpioevents: add support for pull-down and floating input pins.

    The pin-mode (ft, pd, pu for floating, pull-down, pull-up) is
    specified after the intr-config (no, eb, ef, er) for each pin.

    Tested on my Raspberry Pi 1B.

    PR:             268504
    Approved by:    manu
    MFC after:      1 week

 tools/test/gpioevents/gpioevents.c | 47 +++++++++++++++++++++++++++++++++-----
 1 file changed, 41 insertions(+), 6 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-12-29 17:03:02 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=bcd22066444374e61025c372668928ad20c8bf4a

commit bcd22066444374e61025c372668928ad20c8bf4a
Author:     Rene Ladan <rene@FreeBSD.org>
AuthorDate: 2022-12-21 21:24:11 +0000
Commit:     Rene Ladan <rene@FreeBSD.org>
CommitDate: 2022-12-29 17:01:36 +0000

    gpioevents: add support for pull-down and floating input pins.

    The pin-mode (ft, pd, pu for floating, pull-down, pull-up) is
    specified after the intr-config (no, eb, ef, er) for each pin.

    Tested on my Raspberry Pi 1B.

    PR:             268504
    Approved by:    manu
    MFC after:      1 week

    (cherry picked from commit 453db42291a3179a51b9bf41ca7dbc0a5298bffa)

    gpioevents: fix some white-space errors

    Fixes:          453db42291a3 - gpioevents: add support for pull-down and floating input pins.
    Approved by:    manu (implicit)
    MFC after:      1 week

    (cherry picked from commit e2f3742ab8b10ba5ec4dc190c5b64e9151bb0d57)

 tools/test/gpioevents/gpioevents.c | 47 +++++++++++++++++++++++++++++++++-----
 1 file changed, 41 insertions(+), 6 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-12-29 17:04:03 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=534470090d987118b9728deda1b28f96ae5d1cec

commit 534470090d987118b9728deda1b28f96ae5d1cec
Author:     Rene Ladan <rene@FreeBSD.org>
AuthorDate: 2022-12-21 21:24:11 +0000
Commit:     Rene Ladan <rene@FreeBSD.org>
CommitDate: 2022-12-29 17:02:37 +0000

    gpioevents: add support for pull-down and floating input pins.

    The pin-mode (ft, pd, pu for floating, pull-down, pull-up) is
    specified after the intr-config (no, eb, ef, er) for each pin.

    Tested on my Raspberry Pi 1B.

    PR:             268504
    Approved by:    manu
    MFC after:      1 week

    (cherry picked from commit 453db42291a3179a51b9bf41ca7dbc0a5298bffa)

    gpioevents: fix some white-space errors

    Fixes:          453db42291a3 - gpioevents: add support for pull-down and floating input pins.
    Approved by:    manu (implicit)
    MFC after:      1 week

    (cherry picked from commit e2f3742ab8b10ba5ec4dc190c5b64e9151bb0d57)

 tools/test/gpioevents/gpioevents.c | 47 +++++++++++++++++++++++++++++++++-----
 1 file changed, 41 insertions(+), 6 deletions(-)