Bug 268584 - www/tor-browser: please do not create config folder or profiles.ini in ~ (${HOME}) directory
Summary: www/tor-browser: please do not create config folder or profiles.ini in ~ (${H...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rene Ladan
URL:
Keywords:
: 268590 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-12-26 23:16 UTC by Slawomir Wojciech Wojtczak
Modified: 2023-02-12 15:35 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd)

Attachments
profile root dir patch, add to files (412 bytes, text/plain)
2023-01-15 13:53 UTC, Jesper Schmitz Mouridsen 		jsm: maintainer-approval?
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Slawomir Wojciech Wojtczak 2022-12-26 23:16:38 UTC 
Hi,

as much as appreciate the Tor Browser on FreeBSD ... creating the config in the main HOME dir is definitelly not wanted.

% ls ~ | grep default
f5o2xdjb.default

Please use ~/.config/tor-browser so ~/.config/tor-browser/f5o2xdjb.default will be created ... or something similar.

Regards.
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2022-12-27 04:32:09 UTC 
% cat ~/profiles.ini 
[Profile0]
Name=default
IsRelative=1
Path=1lktvvnd.default
Default=1

[General]
StartWithLastProfile=1
Version=2

% 


Whatever the fix for comment #0, should also lead to a better path (not the root of the home directory) for the profiles.ini file. 

Thanks
Comment 2 Slawomir Wojciech Wojtczak 2022-12-27 08:39:14 UTC 
I have modified the ~/profiles.ini with '.tor-browser/' prefix for 'Path' so at least Tor Browser profile is not in the ${HOME} directory directly:

    % cat profiles.ini 
    [Profile0]
    Name=default
    IsRelative=1
    Path=.tor-browser/f5o2xdjb.default
    Default=1
    
    [General]
    StartWithLastProfile=1
    Version=2

... but that does not solves the 'problem' of 'unwanted' ~/profiles.ini file.

IMHO it would be great to modify Tor Browser installation/default configuration to at least use ~/.profiles.ini or ~/.tor-browser-profiles.ini instead.

If course the 'preffered' way would be to be compliant with XDG standarts and use ~/.config/tor-browser but ~/.profiles.ini or ~/.tor-browser-profiles.ini and profiles in ~/.tor-browser by default would be a good start.

Regards.
Comment 3 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2023-01-15 13:53:00 UTC 
Created attachment 239486 [details]
profile root dir patch, add to files

This moves profile root into ~/.tor-broser-profiles. And should also move the
cache dir.
Comment 4 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2023-01-16 17:51:16 UTC 
*** Bug 268590 has been marked as a duplicate of this bug. ***
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2023-02-12 15:10:25 UTC 
Committing this together with an upgrade and some other improvements.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-12 15:35:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5ab09c70073a08928f4b3fc3930167dbea964845

commit 5ab09c70073a08928f4b3fc3930167dbea964845
Author:     Jesper Schmitz Mouridsen <jsm@FreeBSD.org>
AuthorDate: 2023-02-12 15:06:41 +0000
Commit:     Rene Ladan <rene@FreeBSD.org>
CommitDate: 2023-02-12 15:34:10 +0000

    www/tor-browser: various improvements

    - use a dedicated directory [1]
    - enable building without PulseAudio, use Gecko framework more [2]

    No PORTREVISION bump because the next commit will update the port
    to a new version.
    PR:             268584 [1]
    PR:             268245 [2] (attachment 3 [details])
    Approved by:    maintainer timeout (freebsd@sysctl.cz, 6 weeks)

 www/tor-browser/Makefile                                   |  8 +-------
 .../files/patch-toolkit_xre_nsXREDirPRovider.cpp (new)     | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 7 deletions(-)