Bug 268646 - devel/simdjson: re-enable build for i386
Summary: devel/simdjson: re-enable build for i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-29 20:32 UTC by Dimitry Andric
Modified: 2022-12-30 22:42 UTC (History)
3 users (show)

See Also:
olevole: maintainer-feedback+

Attachments
devel/simdjson: re-enable build for i386 (1.11 KB, patch)
2022-12-29 20:32 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2022-12-29 20:32:26 UTC 
When devel/simdjson was originally committed, it was disabled for i386 because of "unknown type name '__uint128_t'" errors. These no longer occur with FreeBSD 12.3 and higher, which has clang 10.0.1.

Re-enable the build for i386, and add -DSIMDJSON_NO_PORTABILITY_WARNING to suppress warnings about 64 bit architectures being preferred for this library, since it works fine. (Although obviously performance will not be as great as on 64 bit architectures.)
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2022-12-29 20:32:50 UTC 
Created attachment 239123 [details]
devel/simdjson: re-enable build for i386
Comment 2 Oleg Ginzburg 2022-12-30 07:42:30 UTC 
looks good to me
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-30 22:42:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a0bcb23325f1a10014a4abd695f014b85f39f464

commit a0bcb23325f1a10014a4abd695f014b85f39f464
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-12-30 22:39:00 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-30 22:39:00 +0000

    devel/simdjson: Re-enable build for i386

     - pet portlint

    PR:             268646

 devel/simdjson/Makefile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-30 22:42:55 UTC 
Committed, thanks!