Bug 268709 - multimedia/mediainfo: Update to 22.12
Summary: multimedia/mediainfo: Update to 22.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on: 268708
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-02 09:01 UTC by Daniel Engberg
Modified: 2023-03-13 10:03 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Patch for mediainfo (1.85 KB, patch)
2023-01-02 09:01 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-01-02 09:01:43 UTC
Created attachment 239197 [details]
Patch for mediainfo

* Switch to separate source archives
* Minor rearrangement of port

Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-01-17 07:59:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=77ef81b604ed0821466cd8688a8d1d45acb7c991

commit 77ef81b604ed0821466cd8688a8d1d45acb7c991
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-01-17 07:45:40 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-01-17 07:59:06 +0000

    multimedia/mediainfo: Update to 22.12

    * Switch to separate source archives
    * Minor rearrangement of port

    Changelog: https://github.com/MediaArea/MediaInfo/releases/tag/v22.12

    PR:             268709
    Approved by:    portmgr (maintainer timeout, 2+ weeks)

 multimedia/mediainfo/Makefile | 16 +++++++++-------
 multimedia/mediainfo/distinfo |  6 +++---
 2 files changed, 12 insertions(+), 10 deletions(-)
Comment 2 Michiel van Baak Jansen 2023-02-13 20:55:09 UTC
This update broke the sonarr port:


[v3.0.9.1555] System.EntryPointNotFoundException: MediaInfo_New assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) NzbDrone.Core.MediaFiles.MediaInfo.MediaInfo.MediaInfo_New()
  at NzbDrone.Core.MediaFiles.MediaInfo.MediaInfo..ctor () [0x00006] in <94cd7b3423f248c7a67a2c736a4ed519>:0 
  at NzbDrone.Core.MediaFiles.MediaInfo.VideoFileInfoReader.GetMediaInfo (System.String filename) [0x00021] in <94cd7b3423f248c7a67a2c736a4ed519>:0 

2023-02-09 13:25:33.6|Error|DetectSample|Failed to get runtime from the file, make sure mediainfo is available

Reverting mediainfo to 22.09 makes sonarr work again.

Please can you help in getting this fixed?
Thanks.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-02-14 08:05:34 UTC
Hi,

What version of libmediainfo do you have?

Best regards,
Daniel
Comment 4 Michiel van Baak Jansen 2023-02-14 09:24:00 UTC
(In reply to Daniel Engberg from comment #3)

mediainfo-22.12
libmediainfo-22.12_1

If I manually uninstall those, and install the 22.09 version as can be found in the /quarterly repo, everything works again. (Only reverted those, sonarr package is still the latest)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-02-14 11:42:11 UTC
Ahh, you aren't using this version since the port (and its dependencies) were reverted/changed afterwards.

https://cgit.freebsd.org/ports/commit/multimedia/mediainfo/Makefile?id=77ef81b604ed0821466cd8688a8d1d45acb7c991 --> https://cgit.freebsd.org/ports/commit/multimedia/mediainfo/Makefile?id=23e0e7b1c30fc6f86957a7428e51a5ea9c594291

https://cgit.freebsd.org/ports/commit/multimedia/libmediainfo?id=a0e75401cb3714a9c3638c7c06a431ec4bf7dffd -->
https://cgit.freebsd.org/ports/commit/multimedia/libmediainfo?id=93d0a119a698aa76d582123be9d97c4fedadc6bd

https://cgit.freebsd.org/ports/commit/multimedia/libzen?id=53f16ee6af9fd18e473de92c2863bc0137f3bb0f -->
https://cgit.freebsd.org/ports/commit/multimedia/libzen?id=23e0c77bf218f44eb3593950367258bc60d040e6

While I don't see any obvious changes to the code upstream that might cause this issue it might be due to library mismatch. What you could try first is to rebuild libzen, libmediainfo and mediainfo to assure there isn't a mismatch. I also have another theory but try that first.
Comment 6 Michiel van Baak Jansen 2023-02-14 15:17:23 UTC
rebuilt the ports, reinstalled, same issue

root@sonarr-v3:~ # pkg info libzen
libzen-0.4.40_1,1
Name           : libzen
Version        : 0.4.40_1,1
Installed on   : Tue Feb 14 16:05:00 2023 CET
Origin         : multimedia/libzen
Architecture   : FreeBSD:13:amd64
Prefix         : /usr/local
Categories     : multimedia
Licenses       : ZLIB
Maintainer     : sunpoet@FreeBSD.org
WWW            : https://mediaarea.net/en/MediaInfo
Comment        : ZenLib used by MediaInfo and its library
Shared Libs provided:
        libzen.so.0
Annotations    :
        FreeBSD_version: 1301000
        build_timestamp: 2023-02-14T14:50:28+0000
        built_by       : poudriere-git-3.3.99.20220831
        port_checkout_unclean: no
        port_git_hash  : 23e0c77bf218
        ports_top_checkout_unclean: no
        ports_top_git_hash: 70199f7b79b5
        repo_type      : binary
        repository     : poudriere
Flat size      : 1.03MiB
Description    :
MediaInfo is a convenient unified display of the most relevant technical and
tag data for video and audio files.

Read http://mediaarea.net/en/MediaInfo/Support/Formats for supported formats.

WWW: https://mediaarea.net/en/MediaInfo
WWW: https://github.com/MediaArea/ZenLib
root@sonarr-v3:~ # pkg info libmediainfo
libmediainfo-22.12_1
Name           : libmediainfo
Version        : 22.12_1
Installed on   : Tue Feb 14 16:05:00 2023 CET
Origin         : multimedia/libmediainfo
Architecture   : FreeBSD:13:amd64
Prefix         : /usr/local
Categories     : multimedia
Licenses       : BSD2CLAUSE
Maintainer     : sunpoet@FreeBSD.org
WWW            : https://mediaarea.net/en/MediaInfo
Comment        : MediaInfo library
Options        :
        CURL           : off
Shared Libs required:
        libzen.so.0
Shared Libs provided:
        libmediainfo.so.0
Annotations    :
        FreeBSD_version: 1301000
        build_timestamp: 2023-02-14T14:50:52+0000
        built_by       : poudriere-git-3.3.99.20220831
        port_checkout_unclean: no
        port_git_hash  : 93d0a119a698
        ports_top_checkout_unclean: no
        ports_top_git_hash: 70199f7b79b5
        repo_type      : binary
        repository     : poudriere
Flat size      : 28.1MiB
Description    :
MediaInfo is a convenient unified display of the most relevant technical and
tag data for video and audio files.

Read http://mediaarea.net/en/MediaInfo/Support/Formats for supported formats.

WWW: https://mediaarea.net/en/MediaInfo
WWW: https://github.com/MediaArea/MediaInfoLib
root@sonarr-v3:~ # pkg info mediainfo
mediainfo-22.12
Name           : mediainfo
Version        : 22.12
Installed on   : Tue Feb 14 16:05:02 2023 CET
Origin         : multimedia/mediainfo
Architecture   : FreeBSD:13:amd64
Prefix         : /usr/local
Categories     : multimedia
Licenses       : BSD2CLAUSE
Maintainer     : sunpoet@FreeBSD.org
WWW            : https://mediaarea.net/en/MediaInfo
Comment        : Provides technical and tag information for video and audio files
Shared Libs required:
        libzen.so.0
        libmediainfo.so.0
Annotations    :
        FreeBSD_version: 1301000
        build_timestamp: 2023-02-14T14:54:02+0000
        built_by       : poudriere-git-3.3.99.20220831
        cpe            : cpe:2.3:a:mediaarea:mediainfo:22.12:::::freebsd13:x64
        port_checkout_unclean: no
        port_git_hash  : 23e0e7b1c30f
        ports_top_checkout_unclean: no
        ports_top_git_hash: 70199f7b79b5
        repo_type      : binary
        repository     : poudriere
Flat size      : 72.8KiB
Description    :
MediaInfo is a convenient unified display of the most relevant technical and
tag data for video and audio files.

Read http://mediaarea.net/en/MediaInfo/Support/Formats for supported formats.

WWW: https://mediaarea.net/en/MediaInfo
WWW: https://github.com/MediaArea/MediaInfo
root@sonarr-v3:~ # pkg info sonarr
sonarr-3.0.9.1549
Name           : sonarr
Version        : 3.0.9.1549
Installed on   : Tue Feb 14 16:05:02 2023 CET
Origin         : net-p2p/sonarr
Architecture   : FreeBSD:13:*
Prefix         : /usr/local
Categories     : net-p2p
Licenses       : GPLv3
Maintainer     : michiel@vanbaak.eu
WWW            : https://sonarr.tv
Comment        : PVR for Usenet and BitTorrent users
Options        :
        X11            : off
Annotations    :
        build_timestamp: 2023-02-14T04:55:01+0000
        built_by       : poudriere-git-3.3.99.20220831
        port_checkout_unclean: no
        port_git_hash  : fb16dfecae4a
        ports_top_checkout_unclean: no
        ports_top_git_hash: e84cd768c332
        repo_type      : binary
        repository     : poudriere
Flat size      : 34.0MiB
Description    :
Sonarr is a PVR for Usenet and BitTorrent users.

WWW: https://sonarr.tv

Still same problem

Error:
2023-02-14 16:15:31.3|Error|VideoFileInfoReader|Unable to parse media info from file: /a-linux-iso.mkv

[v3.0.9.1549] System.EntryPointNotFoundException: MediaInfo_New assembly:<unknown assembly> type:<unknown type> member:(null)
  at (wrapper managed-to-native) NzbDrone.Core.MediaFiles.MediaInfo.MediaInfo.MediaInfo_New()
  at NzbDrone.Core.MediaFiles.MediaInfo.MediaInfo..ctor () [0x00006] in M:\BuildAgent\work\63739567f01dbcc2\src\NzbDrone.Core\MediaFiles\MediaInfo\MediaInfoLib.cs:71
  at NzbDrone.Core.MediaFiles.MediaInfo.VideoFileInfoReader.GetMediaInfo (System.String filename) [0x00021] in M:\BuildAgent\work\63739567f01dbcc2\src\NzbDrone.Core\MediaFiles\MediaInfo\VideoFileInfoReader.cs:44
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2023-02-14 15:56:42 UTC
Hmm...

Could you try applying this and rebuilding all three ports (if you remove libzen) and build multimedia/mediainfo it'll build everything else too.
https://projects.pyret.net/files/public/freebsd/mediainfo-revert.patch

I suspect that --disable-dll https://cgit.freebsd.org/ports/tree/multimedia/libmediainfo/Makefile#n22 might be causing issues based on a brief Google-search. If you can remove that (you might need to add a switch to enable it) and fix plist it should do the same as my patch (except that I'm lazy and just reverted the recent commits) so it also uses CMake instead.
Comment 8 Michiel van Baak Jansen 2023-02-14 18:37:58 UTC
(In reply to Daniel Engberg from comment #7)
The rest of the day I wont have time so I'll pick this up again tomorrow morning.
Thanks for responding promptly today!
Comment 9 Michiel van Baak Jansen 2023-02-15 12:34:23 UTC
(In reply to Daniel Engberg from comment #7)
You, Sir, nailed it.

I applied the patch you linked and rebuilt the 4 ports (libzen, libmediainfo, mediainfo, and sonarr was repackaged because mediainfo changed)
I removed libzen (taking all the others with them), pkg update && pkg install sonarr, and THERE WE GO
just to make sure I imported some linux iso's to make sure mediainfo was used to see what was on the iso, and all works as expected.

Would be awesome if this can be pushed to the tree so sonarr works again.
Thanks for the quick help on this one
Comment 10 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-02-20 18:25:05 UTC
(In reply to Michiel van Baak Jansen from comment #9)

Please provide me some commands to test if sonarr is working correctly. Thanks.
Comment 11 Michiel van Baak Jansen 2023-02-20 18:40:48 UTC
(In reply to Po-Chuan Hsieh from comment #10)
You have to run sonarr daemon.

Then either wait for the health checks to run, or import an episode.
It should not complain about mediainfo.
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-03-13 10:03:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0194336dea50b97cf44e51f1991abf785be34caa

commit 0194336dea50b97cf44e51f1991abf785be34caa
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-13 07:50:57 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-03-13 10:02:54 +0000

    multimedia/libmediainfo: Revert to previous commit

    Last commit by maintainer broke users of mediainfo, revert related
    libraries prior to this change
    This retains changes to WWW and pkg-descr and removal of CXXFLAGS

    PR:             268709, 269601
    Reported by:    Michiel van Baak Jansen <michiel@vanbaak.eu>
    Approved by:    portmgr (blanket, maintainer timeout: 3+ weeks)
    Fixes:          93d0a11

 multimedia/libmediainfo/Makefile  | 31 +++++++++++++++++--------------
 multimedia/libmediainfo/distinfo  |  6 +++---
 multimedia/libmediainfo/pkg-plist |  9 +++++++--
 3 files changed, 27 insertions(+), 19 deletions(-)
Comment 13 commit-hook freebsd_committer freebsd_triage 2023-03-13 10:03:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=23f2da840837311b148a38b5bbe60d0dcc51141a

commit 23f2da840837311b148a38b5bbe60d0dcc51141a
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-13 08:04:52 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-03-13 10:02:54 +0000

    multimedia/mediainfo: Revert to previous commit

    Last commit by maintainer broke users of mediainfo, revert related
    libraries prior to this change
    This retains changes to WWW

    PR:             268709, 269601
    Reported by:    Michiel van Baak Jansen <michiel@vanbaak.eu>
    Approved by:    portmgr (blanket, maintainer timeout: 3+ weeks)
    Fixes:          23e0e7b

 multimedia/mediainfo/Makefile | 19 ++++++++++++-------
 multimedia/mediainfo/distinfo |  6 +++---
 2 files changed, 15 insertions(+), 10 deletions(-)
Comment 14 commit-hook freebsd_committer freebsd_triage 2023-03-13 10:03:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90dc81600699c2e7a9918bc641e21d3326af490e

commit 90dc81600699c2e7a9918bc641e21d3326af490e
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-13 07:32:47 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-03-13 10:02:54 +0000

    multimedia/libzen: Revert to previous commit

    Last commit by maintainer broke users of mediainfo, revert related
    libraries prior to this change
    This retains changes to WWW and pkg-descr

    PR:             268709, 269601
    Reported by:    Michiel van Baak Jansen <michiel@vanbaak.eu>
    Approved by:    portmgr (blanket, maintainer timeout: 3+ weeks)
    Fixes:          23e0c77

 multimedia/libzen/Makefile  | 25 +++++++++++++------------
 multimedia/libzen/distinfo  |  6 +++---
 multimedia/libzen/pkg-plist | 13 +++++--------
 3 files changed, 21 insertions(+), 23 deletions(-)