Bug 268785 - databases/phppgadmin issues with PHP 8.0, 8.1
Summary: databases/phppgadmin issues with PHP 8.0, 8.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-06 14:18 UTC by Alexander Ushakov
Modified: 2023-01-09 14:30 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+
dinoex: merge-quarterly+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Ushakov 2023-01-06 14:18:47 UTC 
Current source for databases/phppgadmin port has several well known issues with PHP 8+: https://github.com/phppgadmin/phppgadmin/issues/119#issuecomment-751410900
It looks like this repository is abandoned by developer (no comments for 2 years). May be add patches for these fixes or switch to another github repository? For example https://github.com/ReimuHakurei/phpPgAdmin (I take it from https://github.com/phppgadmin/phppgadmin/pull/159 and it works quite well for me)
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2023-01-07 16:15:18 UTC 
I will test the patches vs. patched version.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-01-08 17:27:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=914d197f6fd8a2d4822da8abd63d7fef490c23ea

commit 914d197f6fd8a2d4822da8abd63d7fef490c23ea
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2023-01-08 17:25:32 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2023-01-08 17:25:32 +0000

    databases/phppgadmin: update to 7.14.3

    - add support for postgres15
    - fix Authentication Bypass
    PR: 268785
    MFH: 2023Q1
    Security: CVE-2021-3850
    Security: https://huntr.dev/bounties/bdf5f216-4499-4225-a737-b28bc6f5801c/

 databases/phppgadmin/Makefile                      |   10 +-
 databases/phppgadmin/distinfo                      |    6 +-
 .../files/patch-adodb-postgres64.inc.php (gone)    |   14 -
 databases/phppgadmin/files/patch-all_db.php (gone) |   11 -
 databases/phppgadmin/pkg-plist                     | 1193 +++++++++++++++++++-
 5 files changed, 1194 insertions(+), 40 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-01-08 17:50:10 UTC 
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=838734926dc5adfefda2b97d7926cc85dd15d084

commit 838734926dc5adfefda2b97d7926cc85dd15d084
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2023-01-08 17:25:32 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2023-01-08 17:48:58 +0000

    databases/phppgadmin: update to 7.14.3

    - add support for postgres15
    - fix Authentication Bypass
    PR: 268785
    MFH: 2023Q1
    Security: CVE-2021-3850
    Security: https://huntr.dev/bounties/bdf5f216-4499-4225-a737-b28bc6f5801c/

    (cherry picked from commit 914d197f6fd8a2d4822da8abd63d7fef490c23ea)

 databases/phppgadmin/Makefile                      |   10 +-
 databases/phppgadmin/distinfo                      |    6 +-
 .../files/patch-adodb-postgres64.inc.php (gone)    |   14 -
 databases/phppgadmin/files/patch-all_db.php (gone) |   11 -
 databases/phppgadmin/pkg-plist                     | 1193 +++++++++++++++++++-
 5 files changed, 1194 insertions(+), 40 deletions(-)
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2023-01-08 17:57:03 UTC 
The patches for PHP 8.0 had been included at 2002-05-09.

Nevertheless I decided to switch to the better maintained fork.
Comment 5 Alexander Ushakov 2023-01-09 14:30:57 UTC 
Thank you very mach!