Bug 268789 - multimedia/mplayer: fix build with clang 15
Summary: multimedia/mplayer: fix build with clang 15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks: 265425
  Show dependency tree / graph
 
Reported: 2023-01-06 20:00 UTC by Dimitry Andric
Modified: 2023-01-06 23:43 UTC (History)
0 users

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly+

Attachments
multimedia/mplayer: fix build with clang 15 (1.39 KB, patch)
2023-01-06 20:00 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2023-01-06 20:00:04 UTC 
During an exp-run for llvm 15 (see bug 265425), it turned out that multimedia/mplayer failed to build with clang 15:

  libmpcodecs/vd_ffmpeg.c:742:24: error: incompatible integer to pointer conversion assigning to 'unsigned char *' from 'VdpVideoSurface' (aka 'unsigned int') [-Wint-conversion]
          mpi->planes[3] = surface;
                         ^ ~~~~~~~

This is because clang 15 now makes the warning about this incompatible conversion into an error by default. Add a cast to suppress the warning.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-01-06 20:00:26 UTC 
Created attachment 239311 [details]
multimedia/mplayer: fix build with clang 15
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-01-06 23:17:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4a33de10dd5bf5c8442830e89b9da08b0dff719f

commit 4a33de10dd5bf5c8442830e89b9da08b0dff719f
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2023-01-06 23:15:56 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2023-01-06 23:15:56 +0000

    multimedia/mplayer: Fix build with clang 15

    PR:             268789
    Reported by:    dim
    MFH:            2023Q1

 multimedia/mplayer/files/patch-libmpcodecs_vd__ffmpeg.c (new) | 11 +++++++++++
 1 file changed, 11 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-01-06 23:18:58 UTC 
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=40def1889dd6dbe2e46a214b8e4265c88860bafa

commit 40def1889dd6dbe2e46a214b8e4265c88860bafa
Author:     Thomas Zander <riggs@FreeBSD.org>
AuthorDate: 2023-01-06 23:15:56 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2023-01-06 23:18:11 +0000

    multimedia/mplayer: Fix build with clang 15

    PR:             268789
    Reported by:    dim
    MFH:            2023Q1

    (cherry picked from commit 4a33de10dd5bf5c8442830e89b9da08b0dff719f)

 multimedia/mplayer/files/patch-libmpcodecs_vd__ffmpeg.c (new) | 11 +++++++++++
 1 file changed, 11 insertions(+)