Bug 268992 - [New port] devel/ptl: Lightweight C++11 multithreading tasking system
Summary: [New port] devel/ptl: Lightweight C++11 multithreading tasking system
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/jrmadsen/PTL
Keywords:
Depends on:
Blocks: 268993
  Show dependency tree / graph
 
Reported: 2023-01-16 21:07 UTC by Erik Jensen
Modified: 2023-03-27 10:05 UTC (History)
2 users (show)

See Also:

Attachments
git diff --staged of new port (2.38 KB, patch)
2023-01-16 21:07 UTC, Erik Jensen 		no flags Details | Diff
git diff --staged of new port - fixed Makefile (2.33 KB, patch)
2023-03-24 13:53 UTC, Erik Jensen 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Jensen 2023-01-16 21:07:07 UTC 
Created attachment 239512 [details]
git diff --staged of new port

Propose to add PTL (Parallel Tasking Library) to ports tree
Comment 1 Erik Jensen 2023-01-16 21:35:35 UTC 
Port passed a `poudriere testport` on 12.3R, 12.4R and 13.1R amd64 on my system.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-24 13:10:41 UTC 
Hi Erik,

There are quite a few issues. From portlint:

WARN: Makefile: [15]: USE_* seen before USES.  According to the porters-handbook, USES must appear first.
WARN: /data/fernape_data/FreeBSD-repos/ports/devel/ptl/pkg-descr: contains less than 2 lines, make it longer if possible.(currently 1 line)
WARN: /data/fernape_data/FreeBSD-repos/ports/devel/ptl/pkg-descr: includes lines that exceed 80 characters.
FATAL: Makefile: [1]: use a tab (not space) after a variable name
FATAL: Makefile: [2]: use a tab (not space) after a variable name
FATAL: Makefile: [3]: use a tab (not space) after a variable name
FATAL: Makefile: [4]: use a tab (not space) after a variable name
FATAL: Makefile: [6]: use a tab (not space) after a variable name
FATAL: Makefile: [7]: use a tab (not space) after a variable name
FATAL: Makefile: [8]: use a tab (not space) after a variable name
FATAL: Makefile: [10]: use a tab (not space) after a variable name
FATAL: Makefile: [11]: use a tab (not space) after a variable name
FATAL: Makefile: [13]: use a tab (not space) after a variable name
FATAL: Makefile: [15]: use a tab (not space) after a variable name
FATAL: Makefile: [16]: use a tab (not space) after a variable name
FATAL: Makefile: [17]: use a tab (not space) after a variable name
FATAL: Makefile: [19]: use a tab (not space) after a variable name
FATAL: Makefile: [21]: use a tab (not space) after a variable name
WARN: Makefile: [23]: use a tab (not space) after a variable name
WARN: Makefile: [24]: use tab (not space) to make indentation
WARN: Makefile: "USES" has to appear earlier.

# USES block
+USES
USE_GITHUB
GH_ACCOUNT
GH_PROJECT
-USES


Would you mind reordering "USES", replacing the tabs and probably cutting the pkg-descr line into two lines?

Thanks!
Comment 3 Erik Jensen 2023-03-24 13:53:57 UTC 
Created attachment 241086 [details]
git diff --staged of new port - fixed Makefile

I attach a new patch here.

I was unaware of the existence of portlint when I submitted the previous patch, but I have started using it actively in the meantime.

Thanks!
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-27 10:04:51 UTC 
Committed,

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-03-27 10:05:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6e66e8aa832e22ec7bf21dd9dea8439023f224e0

commit 6e66e8aa832e22ec7bf21dd9dea8439023f224e0
Author:     Erik Jensen <erik@tenku.dk>
AuthorDate: 2023-03-26 17:51:25 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-03-27 09:59:28 +0000

    devel/ptl: new port. Lightweight C++11 multithreading tasking system

    Parallel Tasking Library is a needed dependency for the upcoming update of
    science/geant4.

    ChangeLog: https://github.com/jrmadsen/PTL

    PR:             268992
    Reported by:    erik@tenku.dk

 devel/Makefile            |  1 +
 devel/ptl/Makefile (new)  | 25 +++++++++++++++++++++++++
 devel/ptl/distinfo (new)  |  3 +++
 devel/ptl/pkg-descr (new) |  2 ++
 devel/ptl/pkg-plist (new) | 35 +++++++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+)