Comment 1 Robert Clausecker 2023-01-21 17:39:07 UTC

Build tested successfully on i386 amd64 FreeBSD 13.1.

As this port has no architecture-dependent files, check if it can be set to NO_ARCH=yes.

Created attachment 239627 [details]
is set to NO_ARCH=yes...

(In reply to Robert Clausecker from comment #1)

Created attachment 239683 [details]
my attachment is a patch.

Comment 4 Nuno Teixeira 2023-01-25 08:45:54 UTC

USES= python:3.9,run

Does it runs only on 3.9? Or could we just use "USES= python:run"?

- delete deprecated "Created by" comment
- define WWW
- define LICENSE_FILE
- add `desktop-file-utils` to USES

Created attachment 239708 [details]
corrections in the patch.

(In reply to Nuno Teixeira from comment #4)

I haven't yet been able to build/run the port with a different version of Python other than 3.9. ╮( ˘⌣˘)╭

So I'm not sure about that.

Comment 6 Nuno Teixeira 2023-01-27 10:05:08 UTC

- USES= desktop-file-utils not needed since .desktop file doesn't define MimeType
  (ignore my requisite on this, I forgot to check it first)

- NLS is doing nothing here because lang/ and lang/locale directories are being
  installed by ".for d in etc >lang< lib plugins resources" do-install target.

  do-install target must be adapted to install lang/* if NLS=ON and prefix
  %%NLS%% needed files in pkg-plist

- remove i386-wine{-devel} options:

---
emulators/i386-wine-devel||2021-11-16|Removed: obsolete, emulators/wine-devel provides i386 support
emulators/i386-wine||2021-11-19|Removed: obsolete, emulators/wine provides i386 support
---

- recomended a variables order check (portclippy)

Created attachment 239749 [details]
playonbsd(v5).patch

>USES= desktop-file-utils is not needed because the .desktop file does not define a MimeType

OK. Maybe I'll want to add a .desktop file in the future, but not today.

>NLS does nothing here

I tried fixing the NLS option. Seems to be ok now, check it out.

>i386-wine-devel Removed: obsolete,

I saw that it was deprecated and removed. However, this port still works for me.

>wine provides i386 support

I know about this too, but on my machines, regular wine does not work with my video card. It can't run 32bit libraries due to some famous nvidia bug. I look forward to when they finish writing WoW64 to throw out the nasty multilib.

I wanted to add i386-wine-devel for legasy and my compatibility. To use it, it was enough for me to substitute its port or installed package, or my version of Wine. It looks like my port won't need it.

Comment 8 commit-hook 2023-01-29 20:27:01 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3228a669a2a7199ecdf9a196f4d044b1a1a8362b

commit 3228a669a2a7199ecdf9a196f4d044b1a1a8362b
Author:     Clockwork <Clockwork6400@protonmail.com>
AuthorDate: 2023-01-29 20:23:46 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-01-29 20:26:00 +0000

    emulators/playonbsd: Revive port: Easily install and run Windows software for use with Wine

    - Submitter becomes maintainer

    WWW:            https://github.com/Clockwork6400/POL-FreeBSD-4
    PR:             269082

 MOVED                                           |   1 -
 emulators/Makefile                              |   1 +
 emulators/playonbsd/Makefile (new)              |  74 ++++
 emulators/playonbsd/distinfo (new)              |   3 +
 emulators/playonbsd/files/playonbsd.sh.in (new) |   3 +
 emulators/playonbsd/pkg-descr (new)             |   3 +
 emulators/playonbsd/pkg-plist (new)             | 437 ++++++++++++++++++++++++
 7 files changed, 521 insertions(+), 1 deletion(-)

Comment 9 Nuno Teixeira 2023-01-29 20:28:13 UTC

Committed, thanks!