Bug 269083 - www/adguardhome: fails to start properly after upgrading
Summary: www/adguardhome: fails to start properly after upgrading
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-21 17:50 UTC by Jony Hudson
Modified: 2023-01-22 17:43 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jony Hudson 2023-01-21 17:50:12 UTC
Commit https://cgit.freebsd.org/ports/commit/?id=95bf6629820c81523de4693a7c6299ed62c7e1f6 which fixes bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268890 introduces an unwanted behaviour: existing adguardhome installations do not restart properly when upgraded, but instead revert to the configuration wizard. This makes sense, since the configuration files are not in the new expected location.

The new behaviour of having the configuration in a more reasonable place is clearly better. I wonder whether a note should be added to UPDATING flagging that existing installations will break, and giving the steps required to update:

mv /usr/local/bin/AdGuardHome.yaml  /usr/local/etc/
# If adguardhome has been started since upgrade
rm -rf /var/db/adguardhome/data/
mv /usr/local/bin/data/ /var/db/adguardhome/data
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-01-22 17:42:50 UTC
Fixed.

Thanks for reporting this issue.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-01-22 17:43:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=940d212ecd7c7226713724aebd6df76483100c3b

commit 940d212ecd7c7226713724aebd6df76483100c3b
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-01-22 17:39:50 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-01-22 17:42:32 +0000

    www/adguardhome: Move config and data files to a new location

    ... when these files are present at old locations.

    PR:             269083
    Reported by:    Jony Hudson <bsd@j-star.org>

 UPDATING                             | 12 ++++++++++++
 www/adguardhome/Makefile             |  2 +-
 www/adguardhome/files/adguardhome.in | 32 +++++++++++++++++++++++++++++++-
 3 files changed, 44 insertions(+), 2 deletions(-)