Created attachment 239643 [details] git format-patch slurm is still alive on GitHub, and has moved from 0.3.3 to 0.4.4 since the port was deprecated and deleted. This patch resurrects the port and makes a few changes to bring it up to date with the current version. The new WWW is https://github.com/mattthias/slurm/wiki/ QA: - builds and runs under poudriere for the following versions: * 13.1-amd64 * 12.3-amd64 * 12.3-i386 -portlint ok -portclippy is happy
Created attachment 239646 [details] Fixed patch I forgot to add it to SUBDIR in net/Makefile
Drop "or *BSD, Linux, HP-UX and Solaris." from pkg-descr "ripped off" should probably say ripped out or removed? Should use USES= ncurses ?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=55abb82a5813067ca9e61ad921e45aaecad6e428 commit 55abb82a5813067ca9e61ad921e45aaecad6e428 Author: Vidar Karlsen <vidar@karlsen.tech> AuthorDate: 2023-01-22 23:09:23 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2023-01-22 23:12:22 +0000 net/slurm: Revive port: Update to 0.4.4 - Submitter becomes maintainer WWW: https://github.com/mattthias/slurm/wiki/ PR: 269101 MOVED | 1 - net/Makefile | 1 + net/slurm/Makefile (new) | 26 ++++++++++++++++++++++++++ net/slurm/distinfo (new) | 3 +++ net/slurm/pkg-descr (new) | 6 ++++++ net/slurm/pkg-plist (new) | 6 ++++++ 6 files changed, 42 insertions(+), 1 deletion(-)
Could you check `man slurm`? It seams not correctly showing mandoc format style, instead it shows a compact block of text. `mandoc -T lint` shows: --- mandoc: work/slurm-upstream-0.4.4/slurm.1:2:2: ERROR: skipping unknown macro: .Dd February 23, 2003 mandoc: work/slurm-upstream-0.4.4/slurm.1:3:2: ERROR: skipping unknown macro: .Dt slurm 1 mandoc: work/slurm-upstream-0.4.4/slurm.1:6:2: ERROR: skipping unknown macro: .Sh NAME mandoc: work/slurm-upstream-0.4.4/slurm.1:9:2: ERROR: skipping unknown macro: .Nm slurm mandoc: work/slurm-upstream-0.4.4/slurm.1:10:2: ERROR: skipping unknown macro: .Op Fl hHz mandoc: work/slurm-upstream-0.4.4/slurm.1:19:2: ERROR: skipping unknown macro: .Bl -tag -width Ds mandoc: work/slurm-upstream-0.4.4/slurm.1:20:2: ERROR: skipping unknown macro: .It Fl h mandoc: work/slurm-upstream-0.4.4/slurm.1:36:2: ERROR: skipping unknown macro: .El mandoc: work/slurm-upstream-0.4.4/slurm.1:1:5: STYLE: lower case character in document title: TH slurm mandoc: work/slurm-upstream-0.4.4/slurm.1:1:2: WARNING: missing date, using "": TH ---
Committed, thanks!
(In reply to Daniel Engberg from comment #2) Sorry Daniel, didn't see your comment. Will re-open this PR so we can fix pkg-descr. Q/A check doesn't complaint about ncurses dependency, but slurm are linked to it: libncursesw.so.9 => /lib/libncursesw.so.9 (0x2471110c2000) --- ncurses: Possible arguments: (none), base, port --- Should we use USES= ncurses:base ?
Just ncurses
(In reply to Daniel Engberg from comment #7) I tried with and without USES= ncurses when I was testing it, and the results looked the same to me (both linked with /lib/libncursesw.so.9) so I decided to go without it for simplicity. But I might have missed something here. I didn't test with ncurses from ports.
(In reply to Nuno Teixeira from comment #6) --- Did not find pkg-config by name 'pkg-config' Found Pkg-config: NO ncursesw6-config found: NO need ['>=5'] Run-time dependency curses found: YES 6.2 --- Upstream recommends 'ncurses' and 'pkgconfig' as dependencies. "ncursesw6-config found: NO need ['>=5']" is caused by: meson.build: # dependency "ncurses" doesn't work on OpenBSD so we use "curses" on all OS curses_dep = dependency('curses', version: '>=5') It can be silenced with "curses_dep = dependency('ncurses', version: '>=5')" but config finds it anyway: "Run-time dependency curses found: YES 6.2" USES+= ncurses pkgconfig Waiting on pkg-descr fix.
Created attachment 239656 [details] A better pkg-descr
Created attachment 239657 [details] Unbotch the man page I found out the man page just needs to be converted by mandoc. I couldn't find any precedence for how to do it, but this works albeit being a bit Q&D.
(In reply to Vidar Karlsen from comment #10) Looks good to me.
(In reply to Vidar Karlsen from comment #11) This is the first time that I see this. The only formats that I know are groff and mandoc, maybe upstream should be informed about it.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4e0f69d752a5a05c823b2f09d37f4bf1d71e7936 commit 4e0f69d752a5a05c823b2f09d37f4bf1d71e7936 Author: Vidar Karlsen <vidar@karlsen.tech> AuthorDate: 2023-01-24 10:30:50 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2023-01-24 10:33:45 +0000 net/slurm: Add required dependencies to USES While here, fix manpage formating with mandoc and simplify pkg-descr. PR: 269101 net/slurm/Makefile | 11 ++++++++--- net/slurm/pkg-descr | 7 ++++--- 2 files changed, 12 insertions(+), 6 deletions(-)