According to bug #268987, comment #4 there are headers that are missing from this port, which are required in order to get one of the kodi plugins to function properly. The inputstream add-on, among other things, is used by the youtube and twitch Kodi add-ons to ensure that streams (especially live broadcasts) gets delivered with much lower latency - which is central to the viewing experience if you're watching a live stream and communicating with other people regarding the stream. Additionally, the inputstream add-on also significantly reduces the delay when scrubbing through video-on-demand on both the youtube and twitch kodi add-ons. So I'd like to know if it's possible that this port can be fixed so that the headers are installed properly. This would allow the port for the inputstream add-on to be unbroken, and permit users of existing configurations to update kodi, without having to reconfigure add-ons to not use inputstream.
Looking at it.
bento4 project generate tarfiles with all the headers (144 files) at the same location, include, which means /usr/include for our case. This is one of the header line in the archive for linux: Bento4-SDK-1-6-0-639.x86_64-unknown-linux/include/Ap4Array.h I suggest for FreeBSD to use an additional directory "Bento4" to store all the header on it. /usr/local/include/Bento4/Ap4Array.h As a result, source code using Bento4 API can include it in both ways #include <Ap4Array.h> with -H /usr/local/include/Bento4/ or #include <Bento4/Ap4Array.h> with -H /usr/local/include/ If this solution looks good for you I can commit the fix ASAP cheers -- rodrigo
(In reply to Rodrigo Osorio from comment #2) I think it's up to decke@ whether that works, as he's the maintainer of the inputstream port.
(In reply to Rodrigo Osorio from comment #2) That sounds good to me since I would not want to pollute our standard include path either. So yes please go ahead and I will fix the inputstream plugin accordingly.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5a29e56fee6ff5e9e599b513b969e44c78d5b12e commit 5a29e56fee6ff5e9e599b513b969e44c78d5b12e Author: Rodrigo Osorio <rodrigo@FreeBSD.org> AuthorDate: 2023-02-13 21:05:44 +0000 Commit: Rodrigo Osorio <rodrigo@FreeBSD.org> CommitDate: 2023-02-13 21:39:30 +0000 multimedia/Bento4: Fix packaging Add missing header files required by multimedia/kodi-addon-inputstream.adaptive Bump portrevision PR: 269415 Reported by: debdrup multimedia/Bento4/Makefile | 5 +- multimedia/Bento4/pkg-plist | 145 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 149 insertions(+), 1 deletion(-)
Committed, thanks
Bernhard, do you want me to open a report for the inputstream port?
(In reply to Daniel Ebdrup Jensen from comment #7) https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270794