Bug 269423 - "Directory not empty" during make delete-old with unremoved old files
Summary: "Directory not empty" during make delete-old with unremoved old files
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: Unspecified
Hardware: powerpc Any
: --- Affects Only Me
Assignee: Dimitry Andric
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-09 00:03 UTC by Piotr Kubaj
Modified: 2023-02-17 14:36 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2023-02-09 00:03:34 UTC 
CURRENT on powerpc64 after LLVM 15 upgrade (I suspect powerpc64le will be similar):
>>> Removing old directories
/usr/lib/clang/14.0.5/share
rmdir: /usr/lib/clang/14.0.5/lib/freebsd: Directory not empty
rmdir: /usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd: Directory not empty
rmdir: /usr/lib/clang/14.0.5/lib: Directory not empty
rmdir: /usr/lib/debug/usr/lib/clang/14.0.5/lib: Directory not empty
/usr/lib/clang/14.0.5/include/xray
/usr/lib/clang/14.0.5/include/sanitizer
/usr/lib/clang/14.0.5/include/profile
/usr/lib/clang/14.0.5/include/ppc_wrappers
/usr/lib/clang/14.0.5/include/openmp_wrappers
/usr/lib/clang/14.0.5/include/fuzzer
/usr/lib/clang/14.0.5/include/cuda_wrappers
/usr/lib/clang/14.0.5/include
rmdir: /usr/lib/clang/14.0.5: Directory not empty
rmdir: /usr/lib/debug/usr/lib/clang/14.0.5: Directory not empty


root@talos-powerpc64:/usr/src # find /usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_static-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats_client-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_minimal-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.so
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-preinit-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan-powerpc64.a
root@talos-powerpc64:/usr/src # find /usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.so.debug
root@talos-powerpc64:/usr/src # find /usr/lib/clang/14.0.5/lib
/usr/lib/clang/14.0.5/lib
/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_static-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats_client-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_minimal-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.so
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-preinit-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan-powerpc64.a
root@talos-powerpc64:/usr/src # find /usr/lib/debug/usr/lib/clang/14.0.5/lib
/usr/lib/debug/usr/lib/clang/14.0.5/lib
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.so.debug
root@talos-powerpc64:/usr/src # find /usr/lib/clang/14.0.5
/usr/lib/clang/14.0.5
/usr/lib/clang/14.0.5/lib
/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_static-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats_client-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_minimal-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.so
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan_cxx-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-preinit-powerpc64.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan-powerpc64.a
root@talos-powerpc64:/usr/src # find /usr/lib/debug/usr/lib/clang/14.0.5
/usr/lib/debug/usr/lib/clang/14.0.5
/usr/lib/debug/usr/lib/clang/14.0.5/lib
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64.so.debug
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-02-09 09:00:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c8f47b28827ca03654ecf7a4605c3c5195b9b655

commit c8f47b28827ca03654ecf7a4605c3c5195b9b655
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-02-09 08:59:54 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-02-09 08:59:54 +0000

    Add libclang_rt files for powerpc64 to ObsoleteFiles.inc

    Since f5024381ac16 we have also built and installed several clang
    runtime support libraries (for sanitizers) on powerpc64, so add entries
    to properly clean these up when upgrading.

    Reported by:    pkubaj
    PR:             269423
    MFC after:      2 weeks

 ObsoleteFiles.inc | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2023-02-09 11:15:51 UTC 
On powerpc64le:
>>> Removing old directories
/usr/lib/clang/14.0.5/share
rmdir: /usr/lib/clang/14.0.5/lib/freebsd: Directory not empty
rmdir: /usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd: Directory not empty
rmdir: /usr/lib/clang/14.0.5/lib: Directory not empty
rmdir: /usr/lib/debug/usr/lib/clang/14.0.5/lib: Directory not empty
/usr/lib/clang/14.0.5/include/xray
/usr/lib/clang/14.0.5/include/sanitizer
/usr/lib/clang/14.0.5/include/profile
/usr/lib/clang/14.0.5/include/ppc_wrappers
/usr/lib/clang/14.0.5/include/openmp_wrappers
/usr/lib/clang/14.0.5/include/fuzzer
/usr/lib/clang/14.0.5/include/cuda_wrappers
/usr/lib/clang/14.0.5/include
rmdir: /usr/lib/clang/14.0.5: Directory not empty
rmdir: /usr/lib/debug/usr/lib/clang/14.0.5: Directory not empty


root@talos-powerpc64le:/usr/src # find /usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats_client-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-basic-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-fdr-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-profiling-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-preinit-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.so
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_minimal-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_static-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan_cxx-powerpc64le.a
root@talos-powerpc64le:/usr/src # find /usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.so.debug
root@talos-powerpc64le:/usr/src # find /usr/lib/clang/14.0.5/lib
/usr/lib/clang/14.0.5/lib
/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats_client-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-basic-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-fdr-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-profiling-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-preinit-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.so
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_minimal-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_static-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan_cxx-powerpc64le.a
root@talos-powerpc64le:/usr/src # find /usr/lib/debug/usr/lib/clang/14.0.5/lib
/usr/lib/debug/usr/lib/clang/14.0.5/lib
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.so.debug
root@talos-powerpc64le:/usr/src # find /usr/lib/clang/14.0.5
/usr/lib/clang/14.0.5
/usr/lib/clang/14.0.5/lib
/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats_client-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-basic-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-fdr-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-profiling-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-preinit-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.so
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_minimal-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan_static-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.msan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.xray-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone_cxx-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.ubsan_standalone-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.stats-powerpc64le.a
/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.tsan_cxx-powerpc64le.a
root@talos-powerpc64le:/usr/src # find /usr/lib/debug/usr/lib/clang/14.0.5
/usr/lib/debug/usr/lib/clang/14.0.5
/usr/lib/debug/usr/lib/clang/14.0.5/lib
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd
/usr/lib/debug/usr/lib/clang/14.0.5/lib/freebsd/libclang_rt.asan-powerpc64le.so.debug
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-02-10 19:11:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1329d49440e9b5111431e57964f28df5539f572a

commit 1329d49440e9b5111431e57964f28df5539f572a
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-02-10 19:10:31 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-02-10 19:10:44 +0000

    Add libclang_rt files for powerpc64le to ObsoleteFiles.inc

    Since f5024381ac16 we have also built and installed several clang
    runtime support libraries (for sanitizers) on powerpc64le, so add
    entries to properly clean these up when upgrading.

    Reported by:    pkubaj
    PR:             269423
    MFC after:      2 weeks

 ObsoleteFiles.inc | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Comment 4 Dimitry Andric freebsd_committer freebsd_triage 2023-02-10 23:37:46 UTC 
Piotr, did I now get all the variations? :)
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2023-02-17 14:36:32 UTC 
Indeed this is now fixed.
Thanks!