Bug 269445 - tzsetwall() was removed with tzcode update
Summary: tzsetwall() was removed with tzcode update
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: Normal Affects Some People
Assignee: Dag-Erling Smørgrav
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-09 18:17 UTC by Val Packett
Modified: 2023-03-10 15:59 UTC (History)
1 user (show)

See Also:
des: mfc-stable13+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2023-02-09 18:17:11 UTC 
Found by trying to build with ld.lld 16 which defaults to --no-undefined-version.

It was gone upstream for ages, we could remove all the mentions of it: https://reviews.freebsd.org/D38409
Comment 1 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2023-02-09 18:36:27 UTC 
https://reviews.freebsd.org/D38445
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-02-09 18:38:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=71e0c8906e1a4ff774f8ae810aeb94af039eedb7

commit 71e0c8906e1a4ff774f8ae810aeb94af039eedb7
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2023-02-09 18:35:34 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2023-02-09 18:35:34 +0000

    tzcode: Resurrect tzsetwall(3) with a deprecation warning.

    This function has been around since 4.4BSD but was dropped upstream in 2020.  This went unnoticed when tzcode was updated.  Bring it back, but prepare for removing it before 14.0 is released.

    PR:             269445
    MFC after:      3 days
    Reported by:    val@packett.cool
    Reviewed by:    emaste
    Differential Revision:  https://reviews.freebsd.org/D38445

 contrib/tzcode/localtime.c | 21 +++++++++++++++++++--
 lib/libc/gen/tzset.3       | 14 +++++++++-----
 2 files changed, 28 insertions(+), 7 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-02-13 13:59:31 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=eab9ed3d48e0842f3114d8582a4c2868a354190b

commit eab9ed3d48e0842f3114d8582a4c2868a354190b
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2023-02-09 18:35:34 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2023-02-13 13:58:41 +0000

    tzcode: Resurrect tzsetwall(3) with a deprecation warning.

    This function has been around since 4.4BSD but was dropped upstream in 2020.  This went unnoticed when tzcode was updated.  Bring it back, but prepare for removing it before 14.0 is released.

    PR:             269445
    MFC after:      3 days
    Reported by:    val@packett.cool
    Reviewed by:    emaste
    Differential Revision:  https://reviews.freebsd.org/D38445

    (cherry picked from commit 71e0c8906e1a4ff774f8ae810aeb94af039eedb7)

 contrib/tzcode/localtime.c | 21 +++++++++++++++++++--
 lib/libc/gen/tzset.3       | 14 +++++++++-----
 2 files changed, 28 insertions(+), 7 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-02-14 22:20:47 UTC 
A commit in branch releng/13.2 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b158a379d2716d55e59978b970c146ff5284f36c

commit b158a379d2716d55e59978b970c146ff5284f36c
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2023-02-09 18:35:34 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2023-02-14 22:19:53 +0000

    tzcode: Resurrect tzsetwall(3) with a deprecation warning.

    This function has been around since 4.4BSD but was dropped upstream in 2020.  This went unnoticed when tzcode was updated.  Bring it back, but prepare for removing it before 14.0 is released.

    PR:             269445
    MFC after:      3 days
    Reported by:    val@packett.cool
    Reviewed by:    emaste
    Differential Revision:  https://reviews.freebsd.org/D38445
    Approved by:    re (cperciva)

    (cherry picked from commit 71e0c8906e1a4ff774f8ae810aeb94af039eedb7)
    (cherry picked from commit eab9ed3d48e0842f3114d8582a4c2868a354190b)

 contrib/tzcode/localtime.c | 21 +++++++++++++++++++--
 lib/libc/gen/tzset.3       | 14 +++++++++-----
 2 files changed, 28 insertions(+), 7 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-03-07 17:21:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a9a38dea37ef4b8a404978de9c5db0ab9f0ba07b

commit a9a38dea37ef4b8a404978de9c5db0ab9f0ba07b
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2023-03-07 16:04:29 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2023-03-07 17:20:49 +0000

    libc: Remove prototype and documentation for tzsetwall().

    PR:             269445
    Reviewed by:    imp
    Differential Revision:  https://reviews.freebsd.org/D38481

 ObsoleteFiles.inc         |  3 +++
 include/time.h            |  1 -
 lib/libc/gen/Makefile.inc |  1 -
 lib/libc/gen/tzset.3      | 22 +++-------------------
 lib/libc/stdtime/ctime.3  |  6 ++----
 5 files changed, 8 insertions(+), 25 deletions(-)