Bug 269628 - [PATCH] devel/collada-dom: fix build under 14-CURRENT
Summary: [PATCH] devel/collada-dom: fix build under 14-CURRENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-17 16:12 UTC by Trenton Schulz
Modified: 2023-02-20 23:42 UTC (History)
2 users (show)

See Also:


Attachments
Patch to use pkgconfig (932 bytes, patch)
2023-02-17 16:12 UTC, Trenton Schulz
trueos: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trenton Schulz 2023-02-17 16:12:09 UTC
Created attachment 240216 [details]
Patch to use pkgconfig

It seems that I had forgotten to include pkgconfig in the Makefile. So, collada-dom would build its own version of minizip, which would result in problems when building with the latest clang on 14-CURRENT.

Adding pkgconfig should pick up the correct minizip.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-02-20 23:38:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ce3b459d13e8463c2f865c61a7582ef76f32d90

commit 9ce3b459d13e8463c2f865c61a7582ef76f32d90
Author:     Trenton Schulz <trueos@norwegianrockcat.com>
AuthorDate: 2023-02-17 23:55:38 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-02-20 23:36:44 +0000

    devel/collada-dom: fix build under 14-CURRENT

    Supply pkgconfig so minizip is found.  This stops the port from
    building its own bundled minizip, avoiding build problems with
    LLVM 15 as used on 14-CURRENT.

    PR:             269628
    MFH:            2023Q1
    Approved by:    eduardo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38689

 devel/collada-dom/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-02-20 23:41:52 UTC
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1ad2d004e4c200b2c7992510e1d2cd6b3cdce947

commit 1ad2d004e4c200b2c7992510e1d2cd6b3cdce947
Author:     Trenton Schulz <trueos@norwegianrockcat.com>
AuthorDate: 2023-02-17 23:55:38 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-02-20 23:40:44 +0000

    devel/collada-dom: fix build under 14-CURRENT

    Supply pkgconfig so minizip is found.  This stops the port from
    building its own bundled minizip, avoiding build problems with
    LLVM 15 as used on 14-CURRENT.

    PR:             269628
    MFH:            2023Q1
    Approved by:    eduardo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38689

    (cherry picked from commit 9ce3b459d13e8463c2f865c61a7582ef76f32d90)

 devel/collada-dom/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-02-20 23:42:40 UTC
Thank you for your contribution.