Bug 269675 - [NEW PORT] graphics/asciinema-agg: Asciinema gif generator
Summary: [NEW PORT] graphics/asciinema-agg: Asciinema gif generator
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://github.com/asciinema/agg
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-19 03:55 UTC by Jesús Daniel Colmenares Oviedo
Modified: 2023-04-30 18:48 UTC (History)
1 user (show)

See Also:


Attachments
asciinema-agg-1.3.0.patch (37.46 KB, patch)
2023-02-19 03:55 UTC, Jesús Daniel Colmenares Oviedo
no flags Details | Diff
asciinema-agg-1.4.0.patch (40.79 KB, patch)
2023-04-12 14:12 UTC, Jesús Daniel Colmenares Oviedo
no flags Details | Diff
agg-1.4.1.patch (43.14 KB, patch)
2023-04-28 17:52 UTC, Jesús Daniel Colmenares Oviedo
DtxdF: maintainer-approval+
Details | Diff
agg-1.4.1.patch (43.36 KB, patch)
2023-04-29 20:53 UTC, Jesús Daniel Colmenares Oviedo
DtxdF: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús Daniel Colmenares Oviedo 2023-02-19 03:55:38 UTC
Created attachment 240251 [details]
asciinema-agg-1.3.0.patch

Description:

agg is a command-like tool for generating animated GIF files from
asciicast v2 files produced by asciinema terminal recorder.

WWW: https://github.com/asciinema/agg

QA:

* portlint: OK (looks fine.)
* testport: OK (poudriere: 13.1-RELEASE, amd64)
Comment 1 Jesús Daniel Colmenares Oviedo 2023-04-12 14:12:51 UTC
Created attachment 241436 [details]
asciinema-agg-1.4.0.patch

Description:

ChangeLog: https://github.com/asciinema/agg/releases/tag/v1.4.0

* added --last-frame-duration option with a default of 3 seconds.
* implemented text underlining in default renderer.
* fixed font lookup when --font-family values are separated with spaces.
* greatly improved font lookup and font fallback behaviour.
* added implicit font fallback to DejaVu Sans and Noto Emoji to help
  with rendering of symbols and emoji (b&w).

QA:

* portlint: OK (looks fine.)
* testport: OK (poudriere: 13.1-RELEASE, amd64)
Comment 2 Jesús Daniel Colmenares Oviedo 2023-04-28 17:52:33 UTC
Created attachment 241831 [details]
agg-1.4.1.patch

Description:

ChangeLog: https://github.com/asciinema/agg/releases/tag/v1.4.1

* Fixed GIF looping
* Removed timestamps from log messages

QA:

* portlint: OK (looks fine.)
* testport: OK (poudriere: 13.1-RELEASE, amd64)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-04-29 17:59:49 UTC
Thank you for your submission.

Please expand pkg-descr to at least three lines.

Check if there is a package you can depend on to get the fonts required by the package.  Asking the user to chase dependencies is not a good idea.
Comment 4 Jesús Daniel Colmenares Oviedo 2023-04-29 20:53:52 UTC
Created attachment 241863 [details]
agg-1.4.1.patch

Description:

* Extend pkg-descr

QA:

* portlint: OK (looks fine.)
* testport: OK (poudriere: 13.1-RELEASE, amd64)
Comment 5 Jesús Daniel Colmenares Oviedo 2023-04-29 20:57:46 UTC
(In reply to Robert Clausecker from comment #3)

Hi Robert,

Normally, when I create a port that needs a program or a dependency that the user can change if he wants, I don't add it as a dependency. For example, my port, pipe-viewer, needs mpv, vlc or a user-defined player. Similarly, a user-defined font-family can be differente from the dependency that the port would use. Of course, this scheme has the drawback that it is not out-of-the-box, but a simple `pkg install dejavu` (or another font-family) may work fine.

Of source, maybe I am wrong, so I can change it to add a font-family as a dependency without any problem.
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-04-29 23:41:35 UTC
I just think it might improve usability.

You could e.g. add an option that adds a dependency on some common font.  This option could be set by default; expert users can unset it if they don't want the font.

Will commit as is.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-04-30 18:44:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c2133565c4fc8e45495fd60a1077496a4c39208f

commit c2133565c4fc8e45495fd60a1077496a4c39208f
Author:     Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org>
AuthorDate: 2023-04-29 20:52:00 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-04-30 18:41:42 +0000

    graphics/asciinema-agg: New port: Asciinema gif generator

    agg is a command-line tool for generating animated GIF files from
    asciicast v2 files produced by asciinema terminal recorder. It uses
    the excellent gifski library to produce optimized, high quality GIF
    output with accurate frame timing.

    WWW: https://github.com/asciinema/agg/

    PR:             269675

 graphics/Makefile                            |   1 +
 graphics/asciinema-agg/Makefile (new)        |  20 ++
 graphics/asciinema-agg/Makefile.crates (new) | 221 +++++++++++++
 graphics/asciinema-agg/distinfo (new)        | 445 +++++++++++++++++++++++++++
 graphics/asciinema-agg/pkg-descr (new)       |   4 +
 graphics/asciinema-agg/pkg-message (new)     |  13 +
 6 files changed, 704 insertions(+)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-04-30 18:48:51 UTC
Thank you for your contribution.