Created attachment 240282 [details] security/0d1n: fix build When the last update to security/0d1n was committed (cf bug #268423), the committer forgot to commit a large part of attachment #238857 [details], leading to a broken port. The attached patch fixes the breakage by reintroducing the missing patch bits and by fixing them so they confirm to ports conventions better. While no approval is needed for this (build fix blanket), I'd like the maintainer to review this patch as it is a bit complex and some bits differ from his previous patch. Maintainer, please also check if you can add 0d1n-viewer to the package.
Remove the PORTDOCS line from Makefile when testing this one please.
^Triage: reporter is committer, assign accordingly.
Sorry for that and thanks for catching this!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ffba4d2517e856df64248f66fed326a1742a1e3c commit ffba4d2517e856df64248f66fed326a1742a1e3c Author: Robert Clausecker <fuz@FreeBSD.org> AuthorDate: 2023-02-20 12:46:34 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-02-24 08:50:04 +0000 security/0d1n: fix build - convert static REINPLACE_CMD to patch files as per policy - remove remaining <alloca.h> uses - patch getopt_long use on targets where char is unsigned - work around missing __GNUC_PREREQ macro - fix other missing includes - update pkg-plist to what the maintainer intended to pack - patch /opt/0d1n to ${DATADIR} in the relevant files - note that project is dual licensed (upstream has since removed the GPLv3 license) - define LICENSE_FILE_{GPLv3,BSD3CLAUSE} PR: 269717 Fixes: 88dd085ff7851bb2906039d97a81857fe6d8b2e3 Approved by: portmgr (build fix blanket) Approved by: flo (mentor) Differential Revision: https://reviews.freebsd.org/D38725 security/0d1n/Makefile | 22 +++++++++-------- .../patch-0d1n__viewer_lib_krypton_krypton.c (new) | 14 +++++++++++ ...tch-0d1n__viewer_lib_krypton_src_ktypes.h (new) | 14 +++++++++++ security/0d1n/files/patch-src_0d1n.c (new) | 12 ++++++++++ .../0d1n/files/patch-src_headers_file__ops.h (new) | 10 ++++++++ .../0d1n/files/patch-src_headers_results.h (new) | 10 ++++++++ .../0d1n/files/patch-src_headers_spider.h (new) | 10 ++++++++ security/0d1n/files/patch-src_mem__ops.c (new) | 11 +++++++++ security/0d1n/files/patch-src_opt__extract.c (new) | 11 +++++++++ security/0d1n/files/patch-src_strsec.c (new) | 15 ++++++++++++ security/0d1n/pkg-plist (new) | 28 ++++++++++++++++++++++ 11 files changed, 147 insertions(+), 10 deletions(-)
Created attachment 240531 [details] Patch: fix build [security/0d1n] Build is still failing. https://pkg-status.freebsd.org/beefy4/data/123i386-quarterly/53d87890986f/logs/0d1n-3.8.log it works fine after the patch is applied. Thanks
(In reply to Rihaz Jerrin from comment #5) Hi, The failure you observe is with a version prior to the build fix being applied. You can see that it compiles 0d1n-3.8, whereas the patched version is 0d1n-3.8_1. It can take a few weeks for the current state to reach the ports build cluster.
Hi Robert, Thank you for the update.