Bug 269737 - cad/verilator: Incorrect PYTHON3 variable in resulting makefile
Summary: cad/verilator: Incorrect PYTHON3 variable in resulting makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-21 15:07 UTC by Joel Bodenmann
Modified: 2023-02-21 17:38 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Bodenmann freebsd_committer freebsd_triage 2023-02-21 15:07:54 UTC 
After building cad/verilator (with default options) via poudriere, then installing the resulting package, /usr/share/verilator/include/verilated.mk contains this:

PYTHON3 = /wrkdirs/usr/ports/cad/verilator/work/.bin/python3

Other variables (such as AR, CXX, PERL etc) seem to be correct.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-02-21 17:06:32 UTC 
(In reply to Joel Bodenmann from comment #0)

Hi Joel,

Thanks for reporting this problem.

Interestingly, I used verilator intensely not long ago and never experienced any problems.

The fix will be in soon.


Yuri
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-02-21 17:29:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ce5ece11624823e643d415eabd3f7c1bc7995e5a

commit ce5ece11624823e643d415eabd3f7c1bc7995e5a
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-02-21 16:09:51 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-02-21 17:28:50 +0000

    cad/verilator: Fix wrong PYTHON3 path in installed makefile

    PR:             269737
    Reported by:    Joel Bodenmann <jbo@insane.engineer>

 cad/verilator/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-02-21 17:34:08 UTC 
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e2a6ef9db93f0be02fad90d43550a608ccd07795

commit e2a6ef9db93f0be02fad90d43550a608ccd07795
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-02-21 16:09:51 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-02-21 17:33:32 +0000

    cad/verilator: Fix wrong PYTHON3 path in installed makefile

    PR:             269737
    Reported by:    Joel Bodenmann <jbo@insane.engineer>

    (cherry picked from commit ce5ece11624823e643d415eabd3f7c1bc7995e5a)

 cad/verilator/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2023-02-21 17:38:30 UTC 
Fix committed.