Bug 269772 - mount tmpfs with nosymfollow unsupported
Summary: mount tmpfs with nosymfollow unsupported
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-23 07:28 UTC by firk
Modified: 2023-03-02 02:41 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description firk 2023-02-23 07:28:28 UTC 
It seems that the only thing to be done is to add "nosymfollow" to tmpfs_opts[] array here: https://cgit.freebsd.org/src/tree/sys/fs/tmpfs/tmpfs_vfsops.c#n94

Or am I missed something?
Comment 1 Konstantin Belousov freebsd_committer freebsd_triage 2023-02-23 11:26:05 UTC 
Did you tested that?
Comment 2 Konstantin Belousov freebsd_committer freebsd_triage 2023-02-23 13:16:54 UTC 
The tmpfs_updateopts array also should be updated.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-02-23 13:18:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=15df90218bb62df96ce27f47ad9953f4c1f37900

commit 15df90218bb62df96ce27f47ad9953f4c1f37900
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2023-02-23 13:15:17 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2023-02-23 13:15:17 +0000

    tmpfs: support the nosymfollow mount option

    PR:     269772
    Reported by:    firk@cantconnect.ru
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week

 sys/fs/tmpfs/tmpfs_vfsops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 firk 2023-02-28 20:27:56 UTC 
I tested that on 12.3 and it works.
Now tested on CURRENT and it works too.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-03-02 02:31:18 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=84494004f9258b90f34c535cc5de6a176b0ee2b0

commit 84494004f9258b90f34c535cc5de6a176b0ee2b0
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2023-02-23 13:15:17 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2023-03-02 02:30:24 +0000

    tmpfs: support the nosymfollow mount option

    PR:     269772

    (cherry picked from commit 15df90218bb62df96ce27f47ad9953f4c1f37900)

 sys/fs/tmpfs/tmpfs_vfsops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)