ACK
howdy! life just happened and this was put in a hold for a while -- gonna give a shot to get it updated over the upcoming days (aka weekend). goal is definitely to get https://github.com/ooni/probe-cli/releases/tag/v3.18.1 working here.
hello there! it seems we are currently blocked by some unsupported features in Go itself. please follow updates related to bug #272643 (I'm linking the issue here as well, just in case). that's also affecting the build of a recent "oonimini" using go121 doesn't seem to fix the issue for us.
Created attachment 244589 [details] 270020___net_ooni-probe-cli.diff sharing the current diff/patch which should give us v3.18.1.
Created attachment 244590 [details] 270020___net_ooni-probe-cli.log log from poudriere; * jail running latest 13R/amd64; piece of upstream code related to the suspected blocker; * https://github.com/ooni/probe-cli/blob/v3.18.1/internal/netxlite/getaddrinfo_cgo.go
tried to build it without CGO enabled, just in case; didn't work either :) fyi.
Well, let's wait for upstream to fix it somehow. :)
Initial support for Go 1.21 Community members asked us to add Go 1.21 support. It is now possible to compile OONI Probe using Go 1.21. Because Psiphon does not support Go 1.21 yet, when you're building using Go 1.21, it would not be possible to use Psiphon as a circumvention tunnel or to run the Psiphon experiment. (Psiphon should finish migrating to Go 1.21 soon, so OONI Probe 3.21 should have full Go 1.21 support.)
Trying to build version 3.21.1 now
Same problem with netxlite as before: # github.com/ooni/probe-cli/v3/internal/netxlite internal/netxlite/getaddrinfo_cgo.go:203:7: could not determine kind of name for C.AF_INET internal/netxlite/getaddrinfo_cgo.go:207:7: could not determine kind of name for C.AF_INET6 internal/netxlite/getaddrinfo_cgo.go:141:20: could not determine kind of name for C.AF_UNSPEC internal/netxlite/getaddrinfo_cgo.go:140:22: could not determine kind of name for C.SOCK_STREAM
Created attachment 249949 [details] update to 3.21.1
(In reply to Rene Ladan from comment #11) How about committing this patch, change the BROKEN message, and remove the deprecation of this port? If I understand correctly, the problem is in Go, not in this port.
I'm all for it!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f2b44b3ae1c0c62d514fd2db5615314ac5884039 commit f2b44b3ae1c0c62d514fd2db5615314ac5884039 Author: Rene Ladan <rene@FreeBSD.org> AuthorDate: 2024-04-22 20:45:26 +0000 Commit: Rene Ladan <rene@FreeBSD.org> CommitDate: 2024-04-22 20:49:22 +0000 net/ooni-probe-cli: update to 3.21.1, still BROKEN Unexpire the port, but it remains broken due to PR 272643. It now depends on the default Go version instead of the removed lang/go118 PR: 270020 net/ooni-probe-cli/Makefile | 11 ++++------- net/ooni-probe-cli/distinfo | 10 +++++----- 2 files changed, 9 insertions(+), 12 deletions(-)
Created attachment 252287 [details] update to 3.22.0 update to 3.22.0, does not compile yet.
Created attachment 252320 [details] fix build, update to 3.22.0 The build is now OK with poudriere in a 14.1-amd64 jail. The version from github runs with this patch on my 15-CURRENT laptop, i.e. it can do speed tests and run instant messaging tests.
(In reply to Rene Ladan from comment #16) Build is also fine on 14.0-i386 and 13.3-amd64
I submitted the an improved version of the fix upstream, see https://github.com/ooni/probe-cli/pull/1639
Version 3.23.0 was released today (not yet with the fix), I'll submit a new PR for that.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=48a92f7511b106e3a75e354454d73cf8db2405de commit 48a92f7511b106e3a75e354454d73cf8db2405de Author: Rene Ladan <rene@FreeBSD.org> AuthorDate: 2024-08-11 09:40:58 +0000 Commit: Rene Ladan <rene@FreeBSD.org> CommitDate: 2024-08-11 09:40:58 +0000 net/ooni-probe-cli: unbreak, update to 3.22.0 PR: 270020 Reported by: alster@vinterdalen.se Approved by: maintainer timeout (egypcio, 15 days) MFH: 2024Q3 net/ooni-probe-cli/Makefile | 5 +---- net/ooni-probe-cli/distinfo | 10 +++++----- .../files/patch-internal_netxlite_getaddrinfo__cgo.go (new) | 10 ++++++++++ 3 files changed, 16 insertions(+), 9 deletions(-)
A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7bea7a19621da40d5055337245ae183ffa2eb7ca commit 7bea7a19621da40d5055337245ae183ffa2eb7ca Author: Rene Ladan <rene@FreeBSD.org> AuthorDate: 2024-08-11 09:40:58 +0000 Commit: Rene Ladan <rene@FreeBSD.org> CommitDate: 2024-08-11 10:15:26 +0000 net/ooni-probe-cli: unbreak, update to 3.22.0 PR: 270020 Reported by: alster@vinterdalen.se Approved by: maintainer timeout (egypcio, 15 days) MFH: 2024Q3 (cherry picked from commit 48a92f7511b106e3a75e354454d73cf8db2405de) net/ooni-probe-cli/Makefile | 5 +---- net/ooni-probe-cli/distinfo | 10 +++++----- .../files/patch-internal_netxlite_getaddrinfo__cgo.go (new) | 10 ++++++++++ 3 files changed, 16 insertions(+), 9 deletions(-)
New tracking bug for 3.23.0 in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280750