Bug 270160 - net/wireshark: Use helpers and remove redundant code
Summary: net/wireshark: Use helpers and remove redundant code
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-12 18:47 UTC by Daniel Engberg
Modified: 2023-03-20 08:41 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Patch for wireshark (929 bytes, patch)
2023-03-12 18:47 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-12 18:47:20 UTC 
Created attachment 240797 [details]
Patch for wireshark

- Use CMAKE_BOOL helper for ANDROIDDUMP option
- Remove related redundant plist code

References:
https://docs.freebsd.org/en/books/porters-handbook/book/#options-cmake_bool
https://docs.freebsd.org/en/books/porters-handbook/book/#options_sub

Compile tested on FreeBSD 13.2-BETA1 (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-03-19 09:30:00 UTC 
Friendly ping
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-03-20 08:41:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=55c08bfbb77e1bebd6594b8c38914b431a913a44

commit 55c08bfbb77e1bebd6594b8c38914b431a913a44
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-20 08:40:03 +0000
Commit:     Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2023-03-20 08:40:03 +0000

    net/wireshark: Rework ANDROIDDUMP

    Use the cmake Bool helper and remove redundant code now that we're not
    using individual _MAN and _LIB subs.

    PR:             270160

 net/wireshark/Makefile | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2023-03-20 08:41:29 UTC 
Thanks.  The bool is nice, and I forgot that when I removed _MAN and _LIB we're left with the implied option.